From: Dan Carpenter <dan.carpenter@oracle.com>
To: t-kristo@ti.com
Cc: linux-clk@vger.kernel.org
Subject: [bug report] clk: ti: divider: add driver internal API for parsing divider data
Date: Wed, 12 Apr 2017 01:16:35 +0300 [thread overview]
Message-ID: <20170411221635.GA23587@mwanda> (raw)
Hello Tero Kristo,
The patch 4f6be5655dc9: "clk: ti: divider: add driver internal API
for parsing divider data" from Feb 9, 2017, leads to the following
static checker warning:
drivers/clk/ti/divider.c:457 ti_clk_register_divider()
warn: 'table' isn't an ERR_PTR
drivers/clk/ti/divider.c
453 if (div->flags & CLKF_SET_RATE_PARENT)
454 flags |= CLK_SET_RATE_PARENT;
455
456 table = _get_div_table_from_setup(div, &width);
457 if (IS_ERR(table))
^^^^^^^^^^^^
This needs to be updated to a NULL check.
458 return (struct clk *)table;
459
460 clk = _register_divider(NULL, setup->name, div->parent,
461 flags, (void __iomem *)reg, div->bit_shift,
462 width, div_flags, table);
regards,
dan carpenter
next reply other threads:[~2017-04-11 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 22:16 Dan Carpenter [this message]
2017-04-12 7:20 ` [bug report] clk: ti: divider: add driver internal API for parsing divider data Tero Kristo
2017-04-12 16:38 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2018-12-17 14:45 Dan Carpenter
2019-01-09 19:45 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411221635.GA23587@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-clk@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).