From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 21 Apr 2017 19:10:43 -0700 From: Stephen Boyd To: Yoshihiro Kaneko Cc: linux-clk@vger.kernel.org, Michael Turquette , Geert Uytterhoeven , Simon Horman , Magnus Damm , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] clk: cs2000: Fix the setting of saved_rate during the resume process Message-ID: <20170422021043.GD7065@codeaurora.org> References: <1492624001-3758-12-git-send-email-ykaneko0929@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1492624001-3758-12-git-send-email-ykaneko0929@gmail.com> List-ID: On 04/20, Yoshihiro Kaneko wrote: > From: Gaku Inami > > In the resume process, there is the case that other drivers call > cs2000_enable before cs2000_resume is called. Since the order of > resume process is not guaranteed, it is needed to reset the clk > rate in any cases before cs2000 is used. > > Also, the current cs2000 driver is using resume_early function. > The using .resume_early is bad idea because the dependency with > other drivers is to be complicated. > > This patch adds to reset the clk rate in cs2000_enable and > changes to use from .resume_early to .resume. > > Signed-off-by: Gaku Inami > Signed-off-by: Hiroyuki Yokoyama > Signed-off-by: Yoshihiro Kaneko > --- Was this supposed to be sent as a series? This is the second patch in the series? In what situation does a driver call clk_prepare() on the clocks in here before the device's resume callback is called? I would think that any devices that use the clks provided by this driver would be probe defered until the clks are registered, so they would be later in the suspend/resume list than this clk driver? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project