Linux clock framework development
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Santosh Shilimkar <ssantosh@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Tero Kristo <t-kristo@ti.com>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver
Date: Tue, 20 Jun 2017 22:12:37 +0200	[thread overview]
Message-ID: <20170620201249.145468-1-arnd@arndb.de> (raw)

CONFIG_COMPILE_TEST allows building a configuration without
TI_SCI_PROTOCOL, which then fails to link:

drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'

This makes it a hard dependency. Right now, that means we can't
actually compile-test the driver unless ARCH_KEYSTONE is set as
well, but we can fix that by allowing TI_MESSAGE_MANAGER to
be selected for COMPILE_TEST as well.

Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/clk/keystone/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/keystone/Kconfig b/drivers/clk/keystone/Kconfig
index 1fea328a36fe..7e9f0176578a 100644
--- a/drivers/clk/keystone/Kconfig
+++ b/drivers/clk/keystone/Kconfig
@@ -8,7 +8,8 @@ config COMMON_CLK_KEYSTONE
 config TI_SCI_CLK
 	tristate "TI System Control Interface clock drivers"
 	depends on (ARCH_KEYSTONE || COMPILE_TEST) && OF
-	default TI_SCI_PROTOCOL
+	depends on TI_SCI_PROTOCOL
+	default ARCH_KEYSTONE
 	---help---
 	  This adds the clock driver support over TI System Control Interface.
 	  If you wish to use clock resources from the PMMC firmware, say Y.
-- 
2.9.0

             reply	other threads:[~2017-06-20 20:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20 20:12 Arnd Bergmann [this message]
2017-06-21 21:50 ` [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Stephen Boyd
2017-06-22  6:09   ` Tero Kristo
2017-06-23  0:39 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170620201249.145468-1-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=ssantosh@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox