* [PATCH] clk: si5351: Do not enable parent clocks on probe
@ 2017-02-04 20:17 Sergej Sawazki
2017-07-21 21:41 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Sergej Sawazki @ 2017-02-04 20:17 UTC (permalink / raw)
To: mturquette, sboyd; +Cc: linux-clk, Sergej Sawazki, Sebastian Hesselbarth
The si5351 driver should not, by default, enable other clocks in
the tree. Let the clients decide when to enable the clocks.
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Signed-off-by: Sergej Sawazki <ce3a@gmx.de>
---
drivers/clk/clk-si5351.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
index b051db4..f9eb590 100644
--- a/drivers/clk/clk-si5351.c
+++ b/drivers/clk/clk-si5351.c
@@ -1442,9 +1442,9 @@ static int si5351_i2c_probe(struct i2c_client *client,
}
if (!IS_ERR(drvdata->pxtal))
- clk_prepare_enable(drvdata->pxtal);
+ clk_prepare(drvdata->pxtal);
if (!IS_ERR(drvdata->pclkin))
- clk_prepare_enable(drvdata->pclkin);
+ clk_prepare(drvdata->pclkin);
/* register xtal input clock gate */
memset(&init, 0, sizeof(init));
@@ -1617,9 +1617,9 @@ static int si5351_i2c_probe(struct i2c_client *client,
err_clk:
if (!IS_ERR(drvdata->pxtal))
- clk_disable_unprepare(drvdata->pxtal);
+ clk_unprepare(drvdata->pxtal);
if (!IS_ERR(drvdata->pclkin))
- clk_disable_unprepare(drvdata->pclkin);
+ clk_unprepare(drvdata->pclkin);
return ret;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: si5351: Do not enable parent clocks on probe
2017-02-04 20:17 [PATCH] clk: si5351: Do not enable parent clocks on probe Sergej Sawazki
@ 2017-07-21 21:41 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2017-07-21 21:41 UTC (permalink / raw)
To: Sergej Sawazki; +Cc: mturquette, linux-clk, Sebastian Hesselbarth
On 02/04, Sergej Sawazki wrote:
> The si5351 driver should not, by default, enable other clocks in
> the tree. Let the clients decide when to enable the clocks.
>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Signed-off-by: Sergej Sawazki <ce3a@gmx.de>
> ---
I'll bite after many months.
> drivers/clk/clk-si5351.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
> index b051db4..f9eb590 100644
> --- a/drivers/clk/clk-si5351.c
> +++ b/drivers/clk/clk-si5351.c
> @@ -1442,9 +1442,9 @@ static int si5351_i2c_probe(struct i2c_client *client,
> }
>
> if (!IS_ERR(drvdata->pxtal))
> - clk_prepare_enable(drvdata->pxtal);
> + clk_prepare(drvdata->pxtal);
> if (!IS_ERR(drvdata->pclkin))
> - clk_prepare_enable(drvdata->pclkin);
> + clk_prepare(drvdata->pclkin);
Why isn't the prepare also removed?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-21 21:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-04 20:17 [PATCH] clk: si5351: Do not enable parent clocks on probe Sergej Sawazki
2017-07-21 21:41 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).