Linux clock framework development
 help / color / mirror / Atom feed
From: Jernej Skrabec <jernej.skrabec@siol.net>
To: maxime.ripard@free-electrons.com
Cc: wens@csie.org, mturquette@baylibre.com, sboyd@codeaurora.org,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: [PATCH 2/4] clk: sunxi-ng: multiplier: Fix fractional mode
Date: Sun, 30 Jul 2017 18:41:48 +0200	[thread overview]
Message-ID: <20170730164150.26302-3-jernej.skrabec@siol.net> (raw)
In-Reply-To: <20170730164150.26302-1-jernej.skrabec@siol.net>

Driver for multiplier clock is missing a call to
ccu_frac_helper_enable() when fractional mode is selected.

Add a call to ccu_frac_helper_enable().

Fixes: d77e8135b340 ("clk: sunxi-ng: multiplier: Add fractional support")
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
 drivers/clk/sunxi-ng/ccu_mult.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/sunxi-ng/ccu_mult.c b/drivers/clk/sunxi-ng/ccu_mult.c
index 20d0300867f2..ee5e96222cb2 100644
--- a/drivers/clk/sunxi-ng/ccu_mult.c
+++ b/drivers/clk/sunxi-ng/ccu_mult.c
@@ -111,10 +111,13 @@ static int ccu_mult_set_rate(struct clk_hw *hw, unsigned long rate,
 	unsigned long flags;
 	u32 reg;
 
-	if (ccu_frac_helper_has_rate(&cm->common, &cm->frac, rate))
+	if (ccu_frac_helper_has_rate(&cm->common, &cm->frac, rate)) {
+		ccu_frac_helper_enable(&cm->common, &cm->frac);
+
 		return ccu_frac_helper_set_rate(&cm->common, &cm->frac, rate);
-	else
+	} else {
 		ccu_frac_helper_disable(&cm->common, &cm->frac);
+	}
 
 	parent_rate = ccu_mux_helper_apply_prediv(&cm->common, &cm->mux, -1,
 						  parent_rate);
-- 
2.13.3

  parent reply	other threads:[~2017-07-30 16:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-30 16:41 [PATCH 0/4] clk: sunxi-ng: Fix issues with fractional mode Jernej Skrabec
2017-07-30 16:41 ` [PATCH 1/4] clk: sunxi-ng: Fix fractional mode for N-M clocks Jernej Skrabec
2017-07-31  4:54   ` Chen-Yu Tsai
2017-07-30 16:41 ` Jernej Skrabec [this message]
2017-07-31  5:39   ` [PATCH 2/4] clk: sunxi-ng: multiplier: Fix fractional mode Chen-Yu Tsai
2017-07-30 16:41 ` [PATCH 3/4] clk: sunxi-ng: Make fractional helper less chatty Jernej Skrabec
2017-07-31  7:15   ` Chen-Yu Tsai
2017-07-30 16:41 ` [PATCH 4/4] clk: sunxi-ng: Wait for lock when using fractional mode Jernej Skrabec
2017-07-31  5:02   ` Chen-Yu Tsai
2017-07-31 17:18     ` Jernej Škrabec
2017-07-31  5:13 ` [PATCH 0/4] clk: sunxi-ng: Fix issues with " Chen-Yu Tsai
2017-07-31 16:50   ` [linux-sunxi] " Jernej Škrabec
2017-08-01  2:17     ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170730164150.26302-3-jernej.skrabec@siol.net \
    --to=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox