From: Stephen Boyd <sboyd@codeaurora.org>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-clk@vger.kernel.org, mturquette@baylibre.com,
Franklin Cooper <fcooper@ti.com>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH] clk: keystone: sci-clk: Fix sci_clk_get
Date: Wed, 2 Aug 2017 18:38:13 -0700 [thread overview]
Message-ID: <20170803013813.GR2146@codeaurora.org> (raw)
In-Reply-To: <1501698733-27316-1-git-send-email-t-kristo@ti.com>
On 08/02, Tero Kristo wrote:
> Currently a bug in the sci_clk_get implementation causes it to always
> return a clock belonging to the last device in the static list of clock
> data. This is due to a bug in the init code that causes the array
> used by sci_clk_get to only be populated with the clocks for the last
> device, as each device overwrites the entire array with its own clocks.
>
> Fix this by calculating the actual number of clocks for the SoC, and
> allocating the whole array in one go. Also, we don't need the handle
> to the init data array anymore after doing this, instead we can
> just compare the dev_id / clk_id against the registered clocks and
> use binary search for speed.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Reported-by: Dave Gerlach <d-gerlach@ti.com>
> Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
> Cc: Franklin Cooper <fcooper@ti.com>
> Cc: Nishanth Menon <nm@ti.com>
> ---
Applied to clk-fixes
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2017-08-03 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 18:32 [PATCH] clk: keystone: sci-clk: Fix sci_clk_get Tero Kristo
2017-08-02 19:51 ` Franklin S Cooper Jr
2017-08-03 1:38 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803013813.GR2146@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=fcooper@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).