From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 22 Sep 2017 14:36:14 -0700 From: Darren Hart To: Andy Shevchenko Cc: Pierre-Louis Bossart , Carlo Caione , alan@linux.intel.com, Michael Turquette , "open list:COMMON CLK FRAMEWORK" , Stephen Boyd , Linux Upstreaming Team , Enric Balletbo Serra , Carlo Caione Subject: Re: [PATCH v3] clk: x86: Do not gate clocks enabled by the firmware Message-ID: <20170922213614.GA10927@fury> References: <20170714082356.28117-1-carlo@caione.org> <58ef7321-a16d-8974-6a37-db473b6bf48e@linux.intel.com> <1505721917.25945.275.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1505721917.25945.275.camel@linux.intel.com> List-ID: On Mon, Sep 18, 2017 at 11:05:17AM +0300, Andy Shevchenko wrote: > On Thu, 2017-09-07 at 16:51 -0500, Pierre-Louis Bossart wrote: > > > > > > > > > > > Looks like the same code that was initially used as a reference for > > > support of PMC clocks in the clock framework, so now we have 2 > > > drivers > > > programming the same PMC hardware, not so good. We'd probably have > > > to > > > move the atomisp driver to move to clk_get/prepare/enable instead > > > of > > > the old vlv2_clck_get? > > > > See attached an untested change to show the idea on moving to the clk > > API and get feedback (I am not a camera guy, just trying to help - > > compile-tested/checkpatch only). > > This code *should* enable the same functionality using existing hooks > > in > > the kernel (and handle the BYT/CHT clocking difference as a bonus). > > I am sure Andy will have plenty of comments :-) > > I have one comment: nice clean up! > > AtomISP is a *horrible* mess. > Pierre, will you be submitting this patch officially now that you have a tested-by? -- Darren Hart VMware Open Source Technology Center