linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Stephen Boyd <sboyd@codeaurora.org>,
	Michael Turquette <mturquette@baylibre.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>,
	Linus Walleij <linus.walleij@linaro.org>,
	Quentin Schulz <quentin.schulz@free-electrons.com>,
	Kevin Hilman <khilman@baylibre.com>
Subject: [PATCH v4 03/10] clk: add clk_core_set_phase_nolock function
Date: Sun, 24 Sep 2017 22:00:23 +0200	[thread overview]
Message-ID: <20170924200030.6227-4-jbrunet@baylibre.com> (raw)
In-Reply-To: <20170924200030.6227-1-jbrunet@baylibre.com>

Create a core function for set_phase, as it is done for set_rate and
set_parent.

This rework is done to ease the integration of "protected" clock
functionality.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Quentin Schulz <quentin.schulz@free-electrons.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/clk/clk.c | 33 +++++++++++++++++++++------------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 3518f251cfd5..0913688dacb0 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1875,6 +1875,25 @@ int clk_set_parent(struct clk *clk, struct clk *parent)
 }
 EXPORT_SYMBOL_GPL(clk_set_parent);
 
+static int clk_core_set_phase_nolock(struct clk_core *core, int degrees)
+{
+	int ret = -EINVAL;
+
+	lockdep_assert_held(&prepare_lock);
+
+	if (!core)
+		return 0;
+
+	trace_clk_set_phase(core, degrees);
+
+	if (core->ops->set_phase)
+		ret = core->ops->set_phase(core->hw, degrees);
+
+	trace_clk_set_phase_complete(core, degrees);
+
+	return ret;
+}
+
 /**
  * clk_set_phase - adjust the phase shift of a clock signal
  * @clk: clock signal source
@@ -1897,7 +1916,7 @@ EXPORT_SYMBOL_GPL(clk_set_parent);
  */
 int clk_set_phase(struct clk *clk, int degrees)
 {
-	int ret = -EINVAL;
+	int ret;
 
 	if (!clk)
 		return 0;
@@ -1908,17 +1927,7 @@ int clk_set_phase(struct clk *clk, int degrees)
 		degrees += 360;
 
 	clk_prepare_lock();
-
-	trace_clk_set_phase(clk->core, degrees);
-
-	if (clk->core->ops->set_phase)
-		ret = clk->core->ops->set_phase(clk->core->hw, degrees);
-
-	trace_clk_set_phase_complete(clk->core, degrees);
-
-	if (!ret)
-		clk->core->phase = degrees;
-
+	ret = clk_core_set_phase_nolock(clk->core, degrees);
 	clk_prepare_unlock();
 
 	return ret;
-- 
2.13.5

  parent reply	other threads:[~2017-09-24 20:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-24 20:00 [PATCH v4 00/10] clk: implement clock rate protection mechanism Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 01/10] clk: fix incorrect usage of ENOSYS Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 02/10] clk: take the prepare lock out of clk_core_set_parent Jerome Brunet
2017-09-24 20:00 ` Jerome Brunet [this message]
2017-09-24 20:00 ` [PATCH v4 04/10] clk: rework calls to round and determine rate callbacks Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 05/10] clk: use round rate to bail out early in set_rate Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 06/10] clk: add clock protection mechanism to clk core Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 07/10] clk: cosmetic changes to clk_summary debugfs entry Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 08/10] clk: fix CLK_SET_RATE_GATE with clock rate protection Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 09/10] clk: add clk_rate_exclusive api Jerome Brunet
2017-10-26  5:26   ` Michael Turquette
2017-10-31 17:29     ` Jerome Brunet
2017-10-31 17:32       ` Michael Turquette
2017-09-24 20:00 ` [PATCH v4 10/10] clk: fix set_rate_range when current rate is out of range Jerome Brunet
2017-10-26  5:29 ` [PATCH v4 00/10] clk: implement clock rate protection mechanism Michael Turquette
2017-11-02  9:04   ` Maxime Ripard
2017-11-02  9:36     ` Jerome Brunet
2017-11-14  9:04       ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170924200030.6227-4-jbrunet@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mturquette@baylibre.com \
    --cc=quentin.schulz@free-electrons.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).