linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
	linux-clk@vger.kernel.org, Sergej Sawazki <ce3a@gmx.de>,
	Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH 1/2] clk: clk-gpio: Make GPIO clock provider use descriptors only
Date: Thu, 2 Nov 2017 01:21:13 -0700	[thread overview]
Message-ID: <20171102082113.GP11011@codeaurora.org> (raw)
In-Reply-To: <20170924161919.24832-1-linus.walleij@linaro.org>

On 09/24, Linus Walleij wrote:
> After som grep:ing it turns out nothing in the kernel is really calling
> clk_[hw_]_register_gpio_[gate|mux](). All existing instances are just
> created directly from the device tree probe functions at the bottom of
> the clk-gpio.c clock provider file.
> 
> This means we can change the signature of the function without any
> consequences! Everyone should be using GPIO descriptors now, so let's
> just go in and enforce that.
> 
> This saves a bit of code since GPIO descriptors know inherently if they
> are active low so no need for the code keeping track of that.
> 
> We leave it to the caller to come up with the GPIO descriptor. It is
> nowadays possible to do that even without a corresponding device, so
> no excuse not to pass them around. The one in-kernel user lifecycles
> it using devm_gpiod_get() in gpio_clk_driver_probe().
> 
> Cc: Sergej Sawazki <ce3a@gmx.de>
> Cc: Jyri Sarha <jsarha@ti.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

      parent reply	other threads:[~2017-11-02  8:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-24 16:19 [PATCH 1/2] clk: clk-gpio: Make GPIO clock provider use descriptors only Linus Walleij
2017-09-24 16:19 ` [PATCH 2/2] clk: clk-gpio: Request GPIO descriptor as LOW Linus Walleij
2017-09-29 22:53   ` Stephen Boyd
2017-10-01 14:50     ` Linus Walleij
2017-11-02  8:21   ` Stephen Boyd
2017-09-29 22:57 ` [PATCH 1/2] clk: clk-gpio: Make GPIO clock provider use descriptors only Stephen Boyd
2017-10-01 14:53   ` Linus Walleij
2017-10-04 21:21     ` Stephen Boyd
2017-11-02  8:21 ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102082113.GP11011@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=ce3a@gmx.de \
    --cc=jsarha@ti.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).