From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Sat, 4 Nov 2017 14:32:33 +0530 From: Manivannan Sadhasivam To: Rob Herring Cc: mturquette@baylibre.com, sboyd@codeaurora.org, afaerber@suse.de, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, davem@davemloft.net, mchehab@kernel.org, rdunlap@infradead.org, daniel.thompson@linaro.org, amit.kucheria@linaro.org, liuwei@actions-semi.com Subject: Re: [PATCH 1/3] arm64: dts: actions: add s900 clock controller nodes Message-ID: <20171104090230.GA14705@linaro.org> References: <1509479663-8985-1-git-send-email-manivannan.sadhasivam@linaro.org> <1509479663-8985-2-git-send-email-manivannan.sadhasivam@linaro.org> <20171102000616.ug7s7s6fmnubq7y5@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20171102000616.ug7s7s6fmnubq7y5@rob-hp-laptop> List-ID: Hi Rob, On Wed, Nov 01, 2017 at 07:06:16PM -0500, Rob Herring wrote: > On Wed, Nov 01, 2017 at 01:24:21AM +0530, Manivannan Sadhasivam wrote: > > This patch adds clock controller nodes for Actions Semi s900 SoC > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > arch/arm64/boot/dts/actions/s900.dtsi | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900.dtsi > > index 11406f6..c099ef1 100644 > > --- a/arch/arm64/boot/dts/actions/s900.dtsi > > +++ b/arch/arm64/boot/dts/actions/s900.dtsi > > @@ -5,6 +5,7 @@ > > */ > > > > #include > > +#include > > > > / { > > compatible = "actions,s900"; > > @@ -88,6 +89,24 @@ > > #clock-cells = <0>; > > }; > > > > + losc: losc { > > + compatible = "fixed-clock"; > > + clock-frequency = <32768>; > > + #clock-cells = <0>; > > + }; > > + > > + diff_24M: diff_24M { > > + compatible = "fixed-clock"; > > + clock-frequency = <24000000>; > > + #clock-cells = <0>; > > + }; > > These 2 are inputs to the clock ctrlr? The clock controller should have > a clocks property then. > Actually losc and hosc (already defined) are the sources to the clock controller. There isn't much documentation about diff_24M clock which seems to be only sourcing eDP. Since, the vendor driver defined these 3 clocks (losc, hosc, diff_24M) as fixed rate clocks I have added them in the device tree as "fixed-clock" nodes. So, as per your suggestion I will add hosc and losc as clock providers for the clock controller like below in next revision: clocks = <&hosc>, <&losc>; Thanks, Mani > > + > > + clock: clock-controller@e0160000 { > > + compatible = "actions,s900-clock"; > > + reg = <0 0xe0160000 0 0x1000>; > > + #clock-cells = <1>; > > + }; > > + > > soc { > > compatible = "simple-bus"; > > #address-cells = <2>; > > -- > > 2.7.4 > >