From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 11 Nov 2017 00:37:37 +0000 From: Jonathan Cameron To: Martin Blumenstingl Subject: Re: [PATCH v4 0/4] fix the clock setting for SAR ADC Message-ID: <20171111003737.000038f0@huawei.com> In-Reply-To: References: <20171107140942.29243-1-yixun.lan@amlogic.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Neil Armstrong , linux-iio@vger.kernel.org, Stephen Boyd , Michael Turquette , Yixun Lan , linux-kernel@vger.kernel.org, Rob Herring , Xingyu Chen , Kevin Hilman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, Jonathan Cameron , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+mturquette=baylibre.com@lists.infradead.org List-ID: On Tue, 7 Nov 2017 22:36:00 +0100 Martin Blumenstingl wrote: > Hi Yixun, > > On Tue, Nov 7, 2017 at 3:09 PM, Yixun Lan wrote: > > patch [1/4]: > > Fix wrong SARADC/SANA clock gate bit in Meson-GXBB/GXL, > > the published datasheets[4] also has wrong description about this. > > This patch should be explicitly merged *before* other patches. > > > > patch [2-4/4]: > > Drop the "sana" clock from SAR ADC module, > I agree with Jerome that patch 2/4 should be applied last. Let me know when I should take this. Thanks, Jonathan > when I wrote the driver I couldn't get it to work on my GXBB board > (which unfortunately has died since then) because the clocks were > disabled (they weren't enabled by the bootloader). people who are > using an old .dtb would get the same problem again until the clock > driver is merged > > > From the hardware perspective, the SAR ADC module doesn't > > require "sana" clock to wrok. This should apply to all SoC, > > including meson6,8, GXBB, GXL.. > thank you for clarifying this! > > > Note: the whole patchset series has been tested at GXL-P212 board, > > we haven't got any meson6,8 board to test, so I would appreciate > > if someone (Martin?) could help to confirm it works there. > I can test this on a Meson8b and a Meson8m2 board on the weekend - > I'll let you know about the results > > > Regards > Martin > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel