* [PATCH] clk: pxa: fix building on older compilers
@ 2017-09-15 19:53 Arnd Bergmann
2017-09-19 18:46 ` Robert Jarzmik
2017-11-14 23:56 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-09-15 19:53 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Robert Jarzmik
Cc: Arnd Bergmann, linux-clk, linux-kernel
gcc-4.4 got confused by the inline assembler statement:
drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch':
drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token
This removes the extraneous ':' to let all compilers parse the
driver correctly.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/pxa/clk-pxa.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/pxa/clk-pxa.c b/drivers/clk/pxa/clk-pxa.c
index 74f64c3c4290..b80dc9d5855c 100644
--- a/drivers/clk/pxa/clk-pxa.c
+++ b/drivers/clk/pxa/clk-pxa.c
@@ -147,9 +147,7 @@ void pxa2xx_core_turbo_switch(bool on)
" b 3f\n"
"2: b 1b\n"
"3: nop\n"
- : "=&r" (unused)
- : "r" (clkcfg)
- : );
+ : "=&r" (unused) : "r" (clkcfg));
local_irq_restore(flags);
}
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: pxa: fix building on older compilers
2017-09-15 19:53 [PATCH] clk: pxa: fix building on older compilers Arnd Bergmann
@ 2017-09-19 18:46 ` Robert Jarzmik
2017-11-14 23:56 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Robert Jarzmik @ 2017-09-19 18:46 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Michael Turquette, Stephen Boyd, linux-clk, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> gcc-4.4 got confused by the inline assembler statement:
>
> drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch':
> drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token
>
> This removes the extraneous ':' to let all compilers parse the
> driver correctly.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: pxa: fix building on older compilers
2017-09-15 19:53 [PATCH] clk: pxa: fix building on older compilers Arnd Bergmann
2017-09-19 18:46 ` Robert Jarzmik
@ 2017-11-14 23:56 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2017-11-14 23:56 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Michael Turquette, Robert Jarzmik, linux-clk, linux-kernel
On 09/15, Arnd Bergmann wrote:
> gcc-4.4 got confused by the inline assembler statement:
>
> drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch':
> drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token
>
> This removes the extraneous ':' to let all compilers parse the
> driver correctly.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-14 23:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-15 19:53 [PATCH] clk: pxa: fix building on older compilers Arnd Bergmann
2017-09-19 18:46 ` Robert Jarzmik
2017-11-14 23:56 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).