linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] clk: qcom: gcc-msm8916: codec digital clk fixes
@ 2017-12-06 12:11 srinivas.kandagatla
  2017-12-06 12:11 ` [PATCH 1/2] clk: qcom: msm8916: fix mnd_width for codec_digcodec srinivas.kandagatla
  2017-12-06 12:11 ` [PATCH 2/2] clk: qcom: msm8916: add 12.288 MHz support to codec dig clk srinivas.kandagatla
  0 siblings, 2 replies; 5+ messages in thread
From: srinivas.kandagatla @ 2017-12-06 12:11 UTC (permalink / raw)
  To: sboyd, linux-clk; +Cc: linux-arm-msm, linux-kernel, Srinivas Kandagatla

From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

Hi Stephen, 

Found few issues while trying to set 12.288MHz on codec digital clk.
One is to do with missing mnd_width and other is missing clk entry.

thanks,
srini

Srinivas Kandagatla (2):
  clk: qcom: msm8916: fix mnd_width for codec_digcodec
  clk: qcom: msm8916: add 12.288 MHz support to codec dig clk

 drivers/clk/qcom/gcc-msm8916.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.15.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] clk: qcom: msm8916: fix mnd_width for codec_digcodec
  2017-12-06 12:11 [PATCH 0/2] clk: qcom: gcc-msm8916: codec digital clk fixes srinivas.kandagatla
@ 2017-12-06 12:11 ` srinivas.kandagatla
  2017-12-07  6:34   ` Stephen Boyd
  2017-12-06 12:11 ` [PATCH 2/2] clk: qcom: msm8916: add 12.288 MHz support to codec dig clk srinivas.kandagatla
  1 sibling, 1 reply; 5+ messages in thread
From: srinivas.kandagatla @ 2017-12-06 12:11 UTC (permalink / raw)
  To: sboyd, linux-clk; +Cc: linux-arm-msm, linux-kernel, Srinivas Kandagatla

From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

This patch fixes missing mnd_width for codec_digital clk, this is now set to
8 inline with datasheet.

Fixes: 3966fab8b6ab ("clk: qcom: Add MSM8916 Global Clock Controller support")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/clk/qcom/gcc-msm8916.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-msm8916.c b/drivers/clk/qcom/gcc-msm8916.c
index 506e0736bf92..d973aeaab943 100644
--- a/drivers/clk/qcom/gcc-msm8916.c
+++ b/drivers/clk/qcom/gcc-msm8916.c
@@ -1443,6 +1443,7 @@ static const struct freq_tbl ftbl_codec_clk[] = {
 
 static struct clk_rcg2 codec_digcodec_clk_src = {
 	.cmd_rcgr = 0x1c09c,
+	.mnd_width = 8,
 	.hid_width = 5,
 	.parent_map = gcc_xo_gpll1_emclk_sleep_map,
 	.freq_tbl = ftbl_codec_clk,
-- 
2.15.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] clk: qcom: msm8916: add 12.288 MHz support to codec dig clk
  2017-12-06 12:11 [PATCH 0/2] clk: qcom: gcc-msm8916: codec digital clk fixes srinivas.kandagatla
  2017-12-06 12:11 ` [PATCH 1/2] clk: qcom: msm8916: fix mnd_width for codec_digcodec srinivas.kandagatla
@ 2017-12-06 12:11 ` srinivas.kandagatla
  2017-12-07  6:34   ` Stephen Boyd
  1 sibling, 1 reply; 5+ messages in thread
From: srinivas.kandagatla @ 2017-12-06 12:11 UTC (permalink / raw)
  To: sboyd, linux-clk; +Cc: linux-arm-msm, linux-kernel, Srinivas Kandagatla

From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

This patch adds 12.288 MHz suport to codec digital clk, this clock.
Some external PA requires a 12.288 MHz to work.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/clk/qcom/gcc-msm8916.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-msm8916.c b/drivers/clk/qcom/gcc-msm8916.c
index d973aeaab943..d6c7f50ba86a 100644
--- a/drivers/clk/qcom/gcc-msm8916.c
+++ b/drivers/clk/qcom/gcc-msm8916.c
@@ -1436,6 +1436,7 @@ static struct clk_branch gcc_ultaudio_stc_xo_clk = {
 
 static const struct freq_tbl ftbl_codec_clk[] = {
 	F(9600000, P_XO, 2, 0, 0),
+	F(12288000, P_XO, 1, 16, 25),
 	F(19200000, P_XO, 1, 0, 0),
 	F(11289600, P_EXT_MCLK, 1, 0, 0),
 	{ }
-- 
2.15.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] clk: qcom: msm8916: add 12.288 MHz support to codec dig clk
  2017-12-06 12:11 ` [PATCH 2/2] clk: qcom: msm8916: add 12.288 MHz support to codec dig clk srinivas.kandagatla
@ 2017-12-07  6:34   ` Stephen Boyd
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2017-12-07  6:34 UTC (permalink / raw)
  To: srinivas.kandagatla; +Cc: linux-clk, linux-arm-msm, linux-kernel

On 12/06, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> This patch adds 12.288 MHz suport to codec digital clk, this clock.
> Some external PA requires a 12.288 MHz to work.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] clk: qcom: msm8916: fix mnd_width for codec_digcodec
  2017-12-06 12:11 ` [PATCH 1/2] clk: qcom: msm8916: fix mnd_width for codec_digcodec srinivas.kandagatla
@ 2017-12-07  6:34   ` Stephen Boyd
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2017-12-07  6:34 UTC (permalink / raw)
  To: srinivas.kandagatla; +Cc: linux-clk, linux-arm-msm, linux-kernel

On 12/06, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> This patch fixes missing mnd_width for codec_digital clk, this is now set to
> 8 inline with datasheet.
> 
> Fixes: 3966fab8b6ab ("clk: qcom: Add MSM8916 Global Clock Controller support")
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-12-07  6:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-06 12:11 [PATCH 0/2] clk: qcom: gcc-msm8916: codec digital clk fixes srinivas.kandagatla
2017-12-06 12:11 ` [PATCH 1/2] clk: qcom: msm8916: fix mnd_width for codec_digcodec srinivas.kandagatla
2017-12-07  6:34   ` Stephen Boyd
2017-12-06 12:11 ` [PATCH 2/2] clk: qcom: msm8916: add 12.288 MHz support to codec dig clk srinivas.kandagatla
2017-12-07  6:34   ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).