From: Stephen Boyd <sboyd@codeaurora.org>
To: Sergej Sawazki <sergej@taudac.com>
Cc: mturquette@baylibre.com, sebastian.hesselbarth@gmail.com,
linux@armlinux.org.uk, linux-clk@vger.kernel.org, ce3a@gmx.de,
Rabeeh Khoury <rabeeh@solid-run.com>
Subject: Re: [PATCH v2 2/2] clk: si5351: Apply PLL soft reset before enabling the outputs
Date: Thu, 21 Dec 2017 18:11:11 -0800 [thread overview]
Message-ID: <20171222021111.GL7997@codeaurora.org> (raw)
In-Reply-To: <1505562282-9111-3-git-send-email-sergej@taudac.com>
On 09/16, Sergej Sawazki wrote:
> The "Si5351A/B/C Data Sheet" states to apply a PLL soft reset before
> enabling the output clocks [1]. This is required to get a deterministic
> phase relationship between the output clocks.
>
> Without resetting the PLL, the phase relationship between the clocks is
> unpredictable. Fix this by resetting the PLL in si5351_clkout_prepare().
>
> References:
> [1] https://www.silabs.com/Support%20Documents/TechnicalDocs/Si5351-B.pdf
> Figure 12 ("I2C Programming Procedure")
>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Rabeeh Khoury <rabeeh@solid-run.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Signed-off-by: Sergej Sawazki <sergej@taudac.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2017-12-22 2:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 11:44 [PATCH v2 0/2] clk: si5351: PLL reset fixes Sergej Sawazki
2017-09-16 11:44 ` [PATCH v2 1/2] clk: si5351: Add DT property to enable PLL reset Sergej Sawazki
2017-12-22 2:11 ` Stephen Boyd
2017-09-16 11:44 ` [PATCH v2 2/2] clk: si5351: Apply PLL soft reset before enabling the outputs Sergej Sawazki
2017-12-22 2:11 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222021111.GL7997@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=ce3a@gmx.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=rabeeh@solid-run.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sergej@taudac.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).