* [RFC PATCH v1] clk: si5351: Rename internal plls to avoid name collisions
@ 2017-07-25 21:21 Sergej Sawazki
2017-10-12 22:51 ` Stephen Boyd
2017-12-22 2:11 ` Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Sergej Sawazki @ 2017-07-25 21:21 UTC (permalink / raw)
To: sboyd, mturquette
Cc: linux-clk, Sergej Sawazki, Sebastian Hesselbarth, Rabeeh Khoury
This drivers probe fails due to a clock name collision if a clock named
'plla' or 'pllb' is already registered when registering this drivers
internal plls.
Fix it by renaming internal plls to avoid name collisions.
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Rabeeh Khoury <rabeeh@solid-run.com>
Signed-off-by: Sergej Sawazki <sergej@taudac.com>
---
Issue observed on a RaspberryPi with kernel version 4.9.24-v7+, the clock tree
contains clocks named 'plla' and 'pllb'.
drivers/clk/clk-si5351.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
index 6cca425..2866dcd 100644
--- a/drivers/clk/clk-si5351.c
+++ b/drivers/clk/clk-si5351.c
@@ -72,7 +72,7 @@ static const char * const si5351_input_names[] = {
"xtal", "clkin"
};
static const char * const si5351_pll_names[] = {
- "plla", "pllb", "vxco"
+ "si5351_plla", "si5351_pllb", "si5351_vxco"
};
static const char * const si5351_msynth_names[] = {
"ms0", "ms1", "ms2", "ms3", "ms4", "ms5", "ms6", "ms7"
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC PATCH v1] clk: si5351: Rename internal plls to avoid name collisions
2017-07-25 21:21 [RFC PATCH v1] clk: si5351: Rename internal plls to avoid name collisions Sergej Sawazki
@ 2017-10-12 22:51 ` Stephen Boyd
2017-10-14 9:12 ` Sergej Sawazki
2017-12-22 2:11 ` Stephen Boyd
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2017-10-12 22:51 UTC (permalink / raw)
To: Sergej Sawazki
Cc: mturquette, linux-clk, Sebastian Hesselbarth, Rabeeh Khoury
On 07/25, Sergej Sawazki wrote:
> This drivers probe fails due to a clock name collision if a clock named
> 'plla' or 'pllb' is already registered when registering this drivers
> internal plls.
>
> Fix it by renaming internal plls to avoid name collisions.
>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Sergej Sawazki <sergej@taudac.com>
> ---
Is this needed still? I was expecting Sebastian to review.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH v1] clk: si5351: Rename internal plls to avoid name collisions
2017-10-12 22:51 ` Stephen Boyd
@ 2017-10-14 9:12 ` Sergej Sawazki
0 siblings, 0 replies; 4+ messages in thread
From: Sergej Sawazki @ 2017-10-14 9:12 UTC (permalink / raw)
To: Stephen Boyd, Sebastian Hesselbarth; +Cc: mturquette, linux-clk, Rabeeh Khoury
Am 13.10.2017 um 00:51 schrieb Stephen Boyd:
> On 07/25, Sergej Sawazki wrote:
>> This drivers probe fails due to a clock name collision if a clock named
>> 'plla' or 'pllb' is already registered when registering this drivers
>> internal plls.
>>
>> Fix it by renaming internal plls to avoid name collisions.
>
> Is this needed still? I was expecting Sebastian to review.
>
Yes, it is still needed. Can't use the driver on raspberry pi due to a
name collision -- clock names "plla, pllb, plls, plld, pllh" already
used.
Sergej
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH v1] clk: si5351: Rename internal plls to avoid name collisions
2017-07-25 21:21 [RFC PATCH v1] clk: si5351: Rename internal plls to avoid name collisions Sergej Sawazki
2017-10-12 22:51 ` Stephen Boyd
@ 2017-12-22 2:11 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2017-12-22 2:11 UTC (permalink / raw)
To: Sergej Sawazki
Cc: mturquette, linux-clk, Sebastian Hesselbarth, Rabeeh Khoury
On 07/25, Sergej Sawazki wrote:
> This drivers probe fails due to a clock name collision if a clock named
> 'plla' or 'pllb' is already registered when registering this drivers
> internal plls.
>
> Fix it by renaming internal plls to avoid name collisions.
>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Sergej Sawazki <sergej@taudac.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-22 2:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-25 21:21 [RFC PATCH v1] clk: si5351: Rename internal plls to avoid name collisions Sergej Sawazki
2017-10-12 22:51 ` Stephen Boyd
2017-10-14 9:12 ` Sergej Sawazki
2017-12-22 2:11 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).