From: Stephen Boyd <sboyd@codeaurora.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Joel Stanley <joel@jms.id.au>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH -next] clk: aspeed: Fix return value check in aspeed_cc_init()
Date: Wed, 10 Jan 2018 13:19:34 -0800 [thread overview]
Message-ID: <20180110211934.GN21040@codeaurora.org> (raw)
In-Reply-To: <1515116461-156320-1-git-send-email-weiyongjun1@huawei.com>
On 01/05, Wei Yongjun wrote:
> In case of error, the function of_iomap() returns NULL pointer not
> ERR_PTR(). The IS_ERR() test in the return value check should be
> replaced with NULL test.
>
> Fixes: a2e230c7b2ea ("clk: Add clock driver for ASPEED BMC SoCs")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Same comment for this. I suspect coccinelle is finding this but
the semantic patch is not in the kernel repo?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-01-10 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 1:41 [PATCH -next] clk: aspeed: Fix return value check in aspeed_cc_init() Wei Yongjun
2018-01-10 21:19 ` Stephen Boyd [this message]
2018-01-10 21:38 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110211934.GN21040@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=joel@jms.id.au \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox