From: Martin Kaiser <martin@kaiser.cx>
To: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: imx25: set correct parents for ssi ipg clocks
Date: Thu, 8 Mar 2018 15:08:51 +0100 [thread overview]
Message-ID: <20180308140851.GA25601@botnar.kaiser.cx> (raw)
In-Reply-To: <CAOMZO5A7W4rbPbZB8ERs518obrg+6F6mDeojkwJaGComFAJB0A@mail.gmail.com>
Hi Fabio,
Thus wrote Fabio Estevam (festevam@gmail.com):
> I get audio working from SSI1, but I guess this is due to the fact
> that the bootloader enables the SSI clock:
> I have the following in U-Boot:
> /* Enable the clocks */
> DATA 4 0x53f8000c 0x1fffffff
> DATA 4 0x53f80010 0xffffffff
> DATA 4 0x53f80014 0xfdfff
I'm using the same initial settings.
Nevertheless, ssi1_ipg_per is disbled after loading the kernel.
Digging into this a bit more, it turned out that without my patch,
clk_disable_unused() recognizes ssi1_ipg_per as unused and disables it.
If my patch is applied and ssi1_ipg_per is declared as parent of
ssi1_ipg, clk_disable_unused() will not disable it and fsl_ssi_startup()
will enable both ssi1_ipg_per and ssi1_ipg before playing sound.
Best regards,
Martin
next prev parent reply other threads:[~2018-03-08 14:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 22:02 [PATCH] clk: imx25: set correct parents for ssi ipg clocks Martin Kaiser
2018-03-06 22:23 ` Fabio Estevam
2018-03-08 14:08 ` Martin Kaiser [this message]
2018-03-08 15:07 ` Fabio Estevam
2018-03-08 16:46 ` Martin Kaiser
2018-03-09 16:02 ` Lothar Waßmann
2018-03-10 2:37 ` Fabio Estevam
2018-03-11 16:39 ` Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308140851.GA25601@botnar.kaiser.cx \
--to=martin@kaiser.cx \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox