From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 18 Apr 2018 10:32:16 +0800 From: Shawn Guo To: Abel Vesa Cc: Fabio Estevam , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, Abel Vesa , linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] clk: imx: Set CLK_SET_RATE_GATE for gate and divider clocks Message-ID: <20180418023214.GN25429@dragon> References: <1521812006-6173-1-git-send-email-abel.vesa@nxp.com> <1523455409-7771-1-git-send-email-abel.vesa@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1523455409-7771-1-git-send-email-abel.vesa@nxp.com> List-ID: On Wed, Apr 11, 2018 at 05:03:29PM +0300, Abel Vesa wrote: > From: Shawn Guo > > Add flag CLK_SET_RATE_GATE for i.MX gate and divider clocks on which the > client drivers usually make clk_set_rate() call, so that the call will fail > when clock is still on instead of standing the risk of running into glitch > issue. Rate cannot be changed when the clock is enabled due to the glitchy > multiplexers. > > Signed-off-by: Shawn Guo > [initial patch from imx internal repo] > Signed-off-by: Abel Vesa > [carried over from 3.14 and also applied the flag to newer functions] > --- > > Changes since v1: > - changed ownership as per initial patch IIRC, the patch was created on vendor kernel long time ago to work around a specific glitchy multiplexer issue seen on particular SoC. I'm not sure it's good for the upstream kernel today. Shawn