Re: [PATCH] clk: sunxi-ng: replace lib-y with obj-y

[Maxime Ripard <maxime.ripard@bootlin.com>]

[-- Attachment #1: Type: text/plain, Size: 1757 bytes --]

On Wed, Apr 18, 2018 at 04:27:25PM -0700, Stephen Boyd wrote:
> Quoting Masahiro Yamada (2018-04-18 04:52:31)
> > We had commit 06e226c7fb23 ("clk: sunxi-ng: Move all clock types to a
> > library") and commit 799c43415442 ("kbuild: thin archives make default
> > for all archs") in the same development cycle, from different trees.
> > 
> > With migration to the thin archive, the entire drivers/clk/sunxi-ng/lib.a
> > is linked to the vmlinux.  This does not break build, but we do not get
> > any size saving.
> > 
> > However, we do not need to go back to the individual Kconfig options.
> > The default configuration pulls in all (or most) of the CCU parts anyway.
> > Also, once we enable CONFIG_LD_DEAD_CODE_DATA_ELIMINATION, we can simply
> > list all files with obj-y, and the linker will drop all unused functions
> > by itself.
> > 
> > After the long discussion [1], people there agreed to fix this, but
> > nobody sent a patch after all.  I am doing it now.
> > 
> > I lifted up CONFIG_SUNXI_CCU to drivers/clk/Makefile because everything
> > in drivers/clk/sunxi-ng/ depends on SUNXI_CCU.
> > 
> > [1] https://patchwork.kernel.org/patch/9796521/
> > 
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> 
> Thanks for remembering to take care of this. I forgot about it all.
> 
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> 
> Or I can pick this up directly. Let me know.

We'll probably have our usual round of patches that might generate
some conflicts on the Makefile. I've picked it up with your A-b, and
will send you a PR with it, as usual.

Thanks !
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]