Re: [PATCH 08/21] bindings: display: Add compatible for A64 HDMI PHY

Rob Herring
2018-05-01T16:19:09Z

On Mon, Apr 30, 2018 at 05:10:45PM +0530, Jagan Teki wrote:
> HDMI PHY on Allwinner A64 has similar like H3/H5.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> index 9ea4353caadd..7dcd1d64dfe4 100644
> --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> @@ -104,6 +104,7 @@ Required properties:
> - compatible: value must be one of:
> * allwinner,sun8i-a83t-hdmi-phy
> * allwinner,sun8i-h3-hdmi-phy
> + * allwinner,sun50i-a64-hdmi-phy

This should be one valid combination per line. The dts shows that the h3
string is a fallback which should be captured in the binding doc.

> - reg: base address and size of memory-mapped region
> - clocks: phandles to the clocks feeding the HDMI PHY
> * bus: the HDMI PHY interface clock
> --
> 2.14.3
>