From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Lechner <david@lechnology.com>,
Sekhar Nori <nsekhar@ti.com>
Subject: [PATCH 3/5] clk: davinci: no need to check return value of debugfs_create functions
Date: Tue, 29 May 2018 18:08:02 +0200 [thread overview]
Message-ID: <20180529160804.1982-3-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20180529160804.1982-1-gregkh@linuxfoundation.org>
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Cc: David Lechner <david@lechnology.com>
Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/clk/davinci/pll.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/clk/davinci/pll.c b/drivers/clk/davinci/pll.c
index 23a24c944f1d..bb9594703d4a 100644
--- a/drivers/clk/davinci/pll.c
+++ b/drivers/clk/davinci/pll.c
@@ -878,7 +878,6 @@ static int davinci_pll_debug_init(struct clk_hw *hw, struct dentry *dentry)
{
struct davinci_pll_clk *pll = to_davinci_pll_clk(hw);
struct debugfs_regset32 *regset;
- struct dentry *d;
regset = kzalloc(sizeof(*regset), GFP_KERNEL);
if (!regset)
@@ -888,11 +887,7 @@ static int davinci_pll_debug_init(struct clk_hw *hw, struct dentry *dentry)
regset->nregs = ARRAY_SIZE(davinci_pll_regs);
regset->base = pll->base;
- d = debugfs_create_regset32("registers", 0400, dentry, regset);
- if (IS_ERR(d)) {
- kfree(regset);
- return PTR_ERR(d);
- }
+ debugfs_create_regset32("registers", 0400, dentry, regset);
return 0;
}
--
2.17.0
next prev parent reply other threads:[~2018-05-29 16:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 16:08 [PATCH 1/5] clk: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2018-05-29 16:08 ` [PATCH 2/5] clk: bcm2835: " Greg Kroah-Hartman
2018-05-30 19:39 ` Eric Anholt
2018-06-02 2:27 ` Stephen Boyd
2018-05-29 16:08 ` Greg Kroah-Hartman [this message]
2018-05-30 19:03 ` [PATCH 3/5] clk: davinci: " David Lechner
2018-06-02 2:27 ` Stephen Boyd
2018-05-29 16:08 ` [PATCH 4/5] clk: tegra: " Greg Kroah-Hartman
2018-06-02 2:27 ` Stephen Boyd
2018-05-29 16:08 ` [PATCH 5/5] clk: remove clk_debugfs_add_file() Greg Kroah-Hartman
2018-06-02 2:27 ` Stephen Boyd
2018-06-02 2:27 ` [PATCH 1/5] clk: no need to check return value of debugfs_create functions Stephen Boyd
2018-06-02 6:54 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529160804.1982-3-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=david@lechnology.com \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nsekhar@ti.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).