From: Michael Turquette <mturquette@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>, Stephen Boyd <sboyd@kernel.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-soc@vger.kernel.org, David Brown <david.brown@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH 1/2] clk: qcom: drop CLK_SET_RATE_GATE from sdc clocks
Date: Tue, 19 Jun 2018 10:03:07 -0700 [thread overview]
Message-ID: <20180619170307.33232.70445@harbor.lan> (raw)
In-Reply-To: <20180619134051.16726-2-jbrunet@baylibre.com>
Quoting Jerome Brunet (2018-06-19 06:40:50)
> the mmci driver (drivers/mmc/host/mmci.c) does the following sequence:
> * clk_prepare_enable()
> * clk_set_rate()
> =
> on SDCx_clk which is a children of SDCx_src. SDCx_src has
> CLK_SET_RATE_GATE so this sequence should not be allowed but this was not
> enforced. IOW, the flag is ignored. Dropping the flag won't change
> anything to the current behaviour of the platform.
> =
> CLK_SET_RATE_GATE is being fixed and enforced now. If the flag was kept,
> the mmci driver would receive -EBUSY when calling clk_set_rate()
> =
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Applied to clk-qcom-set-rate-gate.
Thanks,
Mike
> ---
> drivers/clk/qcom/gcc-ipq806x.c | 3 ---
> drivers/clk/qcom/gcc-mdm9615.c | 2 --
> drivers/clk/qcom/gcc-msm8660.c | 5 -----
> drivers/clk/qcom/gcc-msm8960.c | 5 -----
> 4 files changed, 15 deletions(-)
> =
> diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806=
x.c
> index 28eb200d0f1e..5f61225657ab 100644
> --- a/drivers/clk/qcom/gcc-ipq806x.c
> +++ b/drivers/clk/qcom/gcc-ipq806x.c
> @@ -1220,7 +1220,6 @@ static struct clk_rcg sdc1_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> @@ -1269,7 +1268,6 @@ static struct clk_rcg sdc3_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> @@ -1353,7 +1351,6 @@ static struct clk_rcg tsif_ref_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> diff --git a/drivers/clk/qcom/gcc-mdm9615.c b/drivers/clk/qcom/gcc-mdm961=
5.c
> index b99dd406e907..849046fbed6d 100644
> --- a/drivers/clk/qcom/gcc-mdm9615.c
> +++ b/drivers/clk/qcom/gcc-mdm9615.c
> @@ -947,7 +947,6 @@ static struct clk_rcg sdc1_src =3D {
> .parent_names =3D gcc_cxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> @@ -996,7 +995,6 @@ static struct clk_rcg sdc2_src =3D {
> .parent_names =3D gcc_cxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> diff --git a/drivers/clk/qcom/gcc-msm8660.c b/drivers/clk/qcom/gcc-msm866=
0.c
> index c347a0d44bc8..7e930e25c79f 100644
> --- a/drivers/clk/qcom/gcc-msm8660.c
> +++ b/drivers/clk/qcom/gcc-msm8660.c
> @@ -1558,7 +1558,6 @@ static struct clk_rcg sdc1_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> @@ -1607,7 +1606,6 @@ static struct clk_rcg sdc2_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> @@ -1656,7 +1654,6 @@ static struct clk_rcg sdc3_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> @@ -1705,7 +1702,6 @@ static struct clk_rcg sdc4_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> @@ -1754,7 +1750,6 @@ static struct clk_rcg sdc5_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm896=
0.c
> index eb551c75fba6..fd495e0471bb 100644
> --- a/drivers/clk/qcom/gcc-msm8960.c
> +++ b/drivers/clk/qcom/gcc-msm8960.c
> @@ -1628,7 +1628,6 @@ static struct clk_rcg sdc1_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> @@ -1677,7 +1676,6 @@ static struct clk_rcg sdc2_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> @@ -1726,7 +1724,6 @@ static struct clk_rcg sdc3_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> @@ -1775,7 +1772,6 @@ static struct clk_rcg sdc4_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> @@ -1824,7 +1820,6 @@ static struct clk_rcg sdc5_src =3D {
> .parent_names =3D gcc_pxo_pll8,
> .num_parents =3D 2,
> .ops =3D &clk_rcg_ops,
> - .flags =3D CLK_SET_RATE_GATE,
> },
> }
> };
> -- =
> 2.14.3
>=20
next prev parent reply other threads:[~2018-06-19 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 13:40 [PATCH 0/2] clk: enforce CLK_SET_RATE_GATE along the tree Jerome Brunet
2018-06-19 13:40 ` [PATCH 1/2] clk: qcom: drop CLK_SET_RATE_GATE from sdc clocks Jerome Brunet
2018-06-19 17:03 ` Michael Turquette [this message]
2018-06-19 13:40 ` [PATCH 2/2] clk: fix CLK_SET_RATE_GATE with clock rate protection Jerome Brunet
2018-06-19 17:03 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619170307.33232.70445@harbor.lan \
--to=mturquette@baylibre.com \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=jbrunet@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=quentin.schulz@free-electrons.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox