public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2] clk: ti: omap3: Fix am3517 mdio clock alias
@ 2018-06-25 10:53 Adam Ford
  2018-06-25 12:16 ` Tero Kristo
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2018-06-25 10:53 UTC (permalink / raw)
  To: adam.ford
  Cc: t-kristo, woods.technical, linux-clk, sboyd, mturquette,
	linux-omap, tony, Adam Ford, stable

A previous patch removed OMAP clock aliases that were perceived
to be unnecessary.  Unfortunately, it broke the ethernet on the
am3517-evm.  This patch enables the MDIO clock and EMAC clock.

Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
Cc: stable@vger.kernel.org #4.16+

Signed-off-by: Adam Ford <aford173@gmail.com>
---
V2:  Instead of modifying clk-3xxx.c, this patch modifie the device tree
     to work like the original patch intended.

diff --git a/arch/arm/boot/dts/am3517.dtsi b/arch/arm/boot/dts/am3517.dtsi
index ca294914bbb1..4b6062b631b1 100644
--- a/arch/arm/boot/dts/am3517.dtsi
+++ b/arch/arm/boot/dts/am3517.dtsi
@@ -39,6 +39,8 @@
 			ti,davinci-ctrl-ram-size = <0x2000>;
 			ti,davinci-rmii-en = /bits/ 8 <1>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
+			clocks = <&emac_ick>;
+			clock-names = "ick";
 		};
 
 		davinci_mdio: ethernet@5c030000 {
@@ -49,6 +51,8 @@
 			bus_freq = <1000000>;
 			#address-cells = <1>;
 			#size-cells = <0>;
+			clocks = <&emac_fck>;
+			clock-names = "fck";
 		};
 
 		uart4: serial@4809e000 {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH V2] clk: ti: omap3: Fix am3517 mdio clock alias
  2018-06-25 10:53 [PATCH V2] clk: ti: omap3: Fix am3517 mdio clock alias Adam Ford
@ 2018-06-25 12:16 ` Tero Kristo
  0 siblings, 0 replies; 2+ messages in thread
From: Tero Kristo @ 2018-06-25 12:16 UTC (permalink / raw)
  To: Adam Ford, adam.ford
  Cc: woods.technical, linux-clk, sboyd, mturquette, linux-omap, tony,
	stable

On 25/06/18 13:53, Adam Ford wrote:

Subject line should be: "ARM: dts: omap3:" etc.

-Tero

> A previous patch removed OMAP clock aliases that were perceived
> to be unnecessary.  Unfortunately, it broke the ethernet on the
> am3517-evm.  This patch enables the MDIO clock and EMAC clock.
> 
> Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
> Cc: stable@vger.kernel.org #4.16+
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2:  Instead of modifying clk-3xxx.c, this patch modifie the device tree
>       to work like the original patch intended.
> 
> diff --git a/arch/arm/boot/dts/am3517.dtsi b/arch/arm/boot/dts/am3517.dtsi
> index ca294914bbb1..4b6062b631b1 100644
> --- a/arch/arm/boot/dts/am3517.dtsi
> +++ b/arch/arm/boot/dts/am3517.dtsi
> @@ -39,6 +39,8 @@
>   			ti,davinci-ctrl-ram-size = <0x2000>;
>   			ti,davinci-rmii-en = /bits/ 8 <1>;
>   			local-mac-address = [ 00 00 00 00 00 00 ];
> +			clocks = <&emac_ick>;
> +			clock-names = "ick";
>   		};
>   
>   		davinci_mdio: ethernet@5c030000 {
> @@ -49,6 +51,8 @@
>   			bus_freq = <1000000>;
>   			#address-cells = <1>;
>   			#size-cells = <0>;
> +			clocks = <&emac_fck>;
> +			clock-names = "fck";
>   		};
>   
>   		uart4: serial@4809e000 {
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-06-25 12:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-25 10:53 [PATCH V2] clk: ti: omap3: Fix am3517 mdio clock alias Adam Ford
2018-06-25 12:16 ` Tero Kristo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox