From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:51591 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965654AbeF0Tu6 (ORCPT ); Wed, 27 Jun 2018 15:50:58 -0400 Date: Wed, 27 Jun 2018 21:50:43 +0200 From: Maxime Ripard To: Jernej Skrabec Cc: wens@csie.org, robh+dt@kernel.org, airlied@linux.ie, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, seanpaul@chromium.org, mark.rutland@arm.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 00/24] Add support for R40 HDMI pipeline Message-ID: <20180627195043.hfasvppfm2cbudx7@flea> References: <20180625120304.7543-1-jernej.skrabec@siol.net> <20180627180215.y5kvvdqeriadxwte@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bezsy6kupmrzsenq" In-Reply-To: <20180627180215.y5kvvdqeriadxwte@flea> Sender: linux-clk-owner@vger.kernel.org List-ID: --bezsy6kupmrzsenq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable 1;5202;0c On Wed, Jun 27, 2018 at 08:02:15PM +0200, Maxime Ripard wrote: > On Mon, Jun 25, 2018 at 02:02:40PM +0200, Jernej Skrabec wrote: > > This series adds support for R40 HDMI pipeline. It is a bit special > > than other already supported pipelines because it has additional unit > > called TCON TOP responsible for relationship configuration between > > mixers, TCONs and HDMI. Additionally, it has additional gates for DSI > > and TV TCONs, TV encoder clock settings and pin muxing between LCD > > and TV encoders. > >=20 > > However, it seems that TCON TOP will become a norm, since newer > > Allwinner SoCs like H6 also have this unit. > >=20 > > I tested different possible configurations: > > - mixer0 <> TCON-TV0 <> HDMI > > - mixer0 <> TCON-TV1 <> HDMI > > - mixer1 <> TCON-TV0 <> HDMI > > - mixer1 <> TCON-TV1 <> HDMI > >=20 > > Please review. >=20 > I just applied it. It didn't apply cleanly, so please make sure it > does next time, or at least state what the dependencies are. And it didn't compile either, because of the compile error that was reported to the previous version by kbuild... Those shouldn't be ignored and simply fixed. Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --bezsy6kupmrzsenq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlsz6pIACgkQ0rTAlCFN r3QHyw//UA9Nx2FAEMfBfKNdc8cDdb5MMoAGgXg8uqNDSjuj5BhCPwiqE6rLZSTS beJSkjmLfBR0CauhVv53vwmGOveNd2Uz0saS3FZY4bO/jLAmGOpB7na0Hlq3pZYH sBuzFTkxollAkHohikoG1avNV2dBDfeFB+RfQ3ElcyJ9C8Bt/dphy4d0Ea4dRSMa NZQ9fJvjPSaKOEFWWOmT6kbvAwkaEgg4g7q3nYltdF3Mlk9tWE5ZaGTRYClXenpb HZoUf0hXSTEs8Ls5CsQlZJvSxmisPJ2OY1ByYxAKVjYZAw0EWMs7rg0/2lA4SvM4 OxswQm4XhB/e0Dtn87OVn7q7Vz0nCZO23g2GBVDTIzTGsfRn8f+3Ma9glcKZsyDL HqdOKrJ0zROS0R6AIMa/OVu46DC+ajUn3w2/h/aBkP8KJfdaN+MqWtDEGOYmq68o wDiz3Dgz3WOg3YLPM8p/94fopkEfihaeRCa+7Drt35Tfo3bI0rB7KIenzLehLnmt Pvu7wDOk5OJiW6u4LU0TLsUoEq4Dd62xhBkyvM7cm6Stn6O13Hnhsn5imTK48hYJ H6QmGW4uEFkXRfYGcQx5WY4IcD7zGNGlcNuCMjhMmvegTY75U1DFgS1W6jsu8hEu NtOK2+L/SsRdksyyUj9rhMQXn/wJhYr45rn/a4pKAJCLvxhJa6E= =L764 -----END PGP SIGNATURE----- --bezsy6kupmrzsenq--