From: Vinod <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH] clk: qcom: gcc-msm8996: Disable halt check on UFS clock
Date: Fri, 6 Jul 2018 10:17:00 +0530 [thread overview]
Message-ID: <20180706044700.GO22377@vkoul-mobl> (raw)
In-Reply-To: <20180705174933.GG2050@tuxbook-pro>
On 05-07-18, 10:49, Bjorn Andersson wrote:
> On Wed 04 Jul 05:19 PDT 2018, Vinod Koul wrote:
>
> Thanks Vinod, sorry for missing the tx clock.
>
> > Commit 12d807cd34b8 ("clk: qcom: gcc-msm8996: Disable halt check on UFS
> > clocks") marked BRANCH_HALT_SKIP for ufs tx clocks, but missed ufs rx
> > clocks. The result of that is kernel warnings at reboot:
>
> "rx clocks"..."tx clock".
will fix
>
> and it wouldn't be unreasonable to have a Fixes: tag.
I did think about it, a miss maynot be called a fix, so was not fully
convinced but as suggested will add
> Apart from that, you have my:
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Thanks, will send v2 now
--
~Vinod
prev parent reply other threads:[~2018-07-06 4:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 12:19 [PATCH] clk: qcom: gcc-msm8996: Disable halt check on UFS clock Vinod Koul
2018-07-05 17:49 ` Bjorn Andersson
2018-07-06 4:47 ` Vinod [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706044700.GO22377@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox