From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Tue, 14 Aug 2018 10:08:57 -0600 From: Rob Herring To: Lucas Stach Cc: Michael Turquette , Stephen Boyd , Shawn Guo , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patchwork-lst@pengutronix.de Subject: Re: [PATCH 2/3] clk: imx6q: optionally get CCM inputs via standard clock handles Message-ID: <20180814160857.GA11979@rob-hp-laptop> References: <20180731102009.6710-1-l.stach@pengutronix.de> <20180731102009.6710-2-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180731102009.6710-2-l.stach@pengutronix.de> List-ID: On Tue, Jul 31, 2018 at 12:20:08PM +0200, Lucas Stach wrote: > When specifying external clock inputs to the CCM the current code > requires the clocks to be in a "clocks" child node of the DT root. > This is not really conformant with DT best practices. > > To avoid the need to deviate from those best practices, allow the > clock inputs to be specifies via standard clock handles. This is > in line with how drivers of the later CCM driver revisions on > newer i.MX SoCs handle this. > > As we can't retroactively change the DT binding, allow this as an > option with a fallback to the old way of how this has been handled. > > Signed-off-by: Lucas Stach > --- > .../devicetree/bindings/clock/imx6q-clock.txt | 5 +++++ Ignoring what my bot said if there's no other changes needed, Acked-by: Rob Herring > drivers/clk/imx/clk-imx6q.c | 22 ++++++++++++++----- > 2 files changed, 22 insertions(+), 5 deletions(-)