From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Sender: Johan Hovold Date: Wed, 29 Aug 2018 09:50:07 +0200 From: Johan Hovold To: Stephen Boyd Cc: Johan Hovold , Tero Kristo , Michael Turquette , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: ti: fix OF child-node lookup Message-ID: <20180829075007.GC28861@localhost> References: <20180822090319.29167-1-johan@kernel.org> <153549552398.129321.2521954503276443182@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <153549552398.129321.2521954503276443182@swboyd.mtv.corp.google.com> List-ID: On Tue, Aug 28, 2018 at 03:32:03PM -0700, Stephen Boyd wrote: > Quoting Johan Hovold (2018-08-22 02:03:19) > > Fix child-node lookup which by using the wrong OF helper was searching > > the whole tree depth-first, something which could end up matching an > > unrelated node. > > > > Also fix the related node-reference leaks. > > > > Fixes: 5b385a45e001 ("clk: ti: add support for clkctrl aliases") > > Found by inspection? Or it's actively causing problems? I'm thinking > it's the former so this can bake in clk-next for a while. Right, through inspection. I fixed up most of these last year, but this one managed to sneak in since then. clk-next should be fine. Thanks, Johan