public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: zyw@rock-chips.com, mturquette@baylibre.com, sboyd@kernel.org,
	w.egorov@phytec.de
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Does Rockchip RK808 driver unload work as intended?
Date: Fri, 7 Sep 2018 13:19:40 +0300	[thread overview]
Message-ID: <20180907101940.GE2472@localhost.localdomain> (raw)

Hi dee Ho peeps,

I was browsing through the clk drivers as I tried to do some cleaning.
Few days ago I submitted a patch which would add devm variants for
clkdev lookup registration. I also added devm of_provider registration
for cases where it is actually the parent device which contains clock
definitions in DT. This seems to be quite typical for MFDs.

While doing this I hit to Rockchip RK808 driver which seems to utilize
oarent device (MFD dev) for pretty much all devm releasing. I wonder if
this is safe? What happens if one tries to remove the RK808 clk module?

I guess the clk deregistration and cleanups are not ran as parent device
stays there, right? But is the clk module and clk module code still
unload? So won't clk operation pointers registered to clk core become
invalid?

I guess I don't have any HW to test this mnyself. And as the driver has
been there since 2014 - well, chances are the driver does work and I
just don't get it =)

So can someone please shed some light on this? Is this a bug or am I
just plain wrong?

Br,
	Matti Vaittinen

             reply	other threads:[~2018-09-07 10:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 10:19 Matti Vaittinen [this message]
2018-09-10  7:28 ` Does Rockchip RK808 driver unload work as intended? Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180907101940.GE2472@localhost.localdomain \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=w.egorov@phytec.de \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox