From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 27 Sep 2018 19:17:47 +0200 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel@lists.freedesktop.org, Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Michael Trimarchi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 12/12] arm64: dts: allwinner: bananapi-m64: Bananapi S070WV20-CT16 DSI panel Message-ID: <20180927171747.wqdt5eiwktyyoefz@flea> References: <20180927114850.24565-1-jagan@amarulasolutions.com> <20180927114850.24565-13-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180927114850.24565-13-jagan@amarulasolutions.com> List-ID: On Thu, Sep 27, 2018 at 05:18:50PM +0530, Jagan Teki wrote: > This patch add support for Bananapi S070WV20-CT16 DSI panel to > BPI-M64 board. >=20 > DSI panel connected via board DSI port with, > - DC1SW as AVDD supply > - DCDC1 as DVDD supply > - PD6 gpio for reset pin > - PD5 gpio for backlight enable pin > - PD7 gpio for backlight vdd supply >=20 > Signed-off-by: Jagan Teki > --- > .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/= arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > index ef1c90401bb2..c0be949be68d 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > @@ -45,6 +45,7 @@ > #include "sun50i-a64.dtsi" > =20 > #include > +#include > =20 > / { > model =3D "BananaPi-M64"; > @@ -56,6 +57,24 @@ > serial1 =3D &uart1; > }; > =20 > + vdd_bl: regulator@0 { > + compatible =3D "regulator-fixed"; > + regulator-name =3D "bl-3v3"; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + gpio =3D <&pio 3 7 GPIO_ACTIVE_HIGH>; /* PD7 */ > + enable-active-high; > + }; > + > + backlight_dsi: backlight-dsi { > + compatible =3D "pwm-backlight"; > + pwms =3D <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; > + brightness-levels =3D <0 10 20 30 40 50 60 70 80 90 100>; The brightness levels should be increasing linearly from a user point of view. Usually, with a PWM backlight, a quadratic rule works much better. MMaxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF14C43382 for ; Thu, 27 Sep 2018 17:17:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4B9D2159D for ; Thu, 27 Sep 2018 17:17:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4B9D2159D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-clk-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727599AbeI0XhG convert rfc822-to-8bit (ORCPT ); Thu, 27 Sep 2018 19:37:06 -0400 Received: from mail.bootlin.com ([62.4.15.54]:60913 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727437AbeI0XhG (ORCPT ); Thu, 27 Sep 2018 19:37:06 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 59263207E5; Thu, 27 Sep 2018 19:17:47 +0200 (CEST) Received: from localhost (unknown [91.116.141.28]) by mail.bootlin.com (Postfix) with ESMTPSA id 0FFDB20795; Thu, 27 Sep 2018 19:17:47 +0200 (CEST) Date: Thu, 27 Sep 2018 19:17:47 +0200 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel@lists.freedesktop.org, Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Michael Trimarchi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 12/12] arm64: dts: allwinner: bananapi-m64: Bananapi S070WV20-CT16 DSI panel Message-ID: <20180927171747.wqdt5eiwktyyoefz@flea> References: <20180927114850.24565-1-jagan@amarulasolutions.com> <20180927114850.24565-13-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20180927114850.24565-13-jagan@amarulasolutions.com> User-Agent: NeoMutt/20180716 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Message-ID: <20180927171747.RVM_adHr8n6gBBPVaU39stnUlrO63K09XE-O1BUI8ZA@z> On Thu, Sep 27, 2018 at 05:18:50PM +0530, Jagan Teki wrote: > This patch add support for Bananapi S070WV20-CT16 DSI panel to > BPI-M64 board. > > DSI panel connected via board DSI port with, > - DC1SW as AVDD supply > - DCDC1 as DVDD supply > - PD6 gpio for reset pin > - PD5 gpio for backlight enable pin > - PD7 gpio for backlight vdd supply > > Signed-off-by: Jagan Teki > --- > .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > index ef1c90401bb2..c0be949be68d 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > @@ -45,6 +45,7 @@ > #include "sun50i-a64.dtsi" > > #include > +#include > > / { > model = "BananaPi-M64"; > @@ -56,6 +57,24 @@ > serial1 = &uart1; > }; > > + vdd_bl: regulator@0 { > + compatible = "regulator-fixed"; > + regulator-name = "bl-3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pio 3 7 GPIO_ACTIVE_HIGH>; /* PD7 */ > + enable-active-high; > + }; > + > + backlight_dsi: backlight-dsi { > + compatible = "pwm-backlight"; > + pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; > + brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; The brightness levels should be increasing linearly from a user point of view. Usually, with a PWM backlight, a quadratic rule works much better. MMaxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com