diff for duplicates of <20180927171831.2nfybgn2xmc4vrgt@flea> diff --git a/a/1.txt b/N1/1.txt index 779be37..5b302f3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,24 +3,22 @@ On Thu, Sep 27, 2018 at 05:18:43PM +0530, Jagan Teki wrote: > share similar way to process command sequence in DSI block so > add generic write 2 param transfer type macro so-that the panels > which are requesting similar transfer type may process properly. ->=20 +> > Also added error check for unsupporting transfer types this make > debugging easy for new transfer types. ->=20 +> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 3 +++ > 1 file changed, 3 insertions(+) ->=20 -> diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun= -4i/sun6i_mipi_dsi.c +> +> diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > index 156b371243c6..1c7e42015645 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c -> @@ -869,6 +869,7 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_hos= -t *host, +> @@ -869,6 +869,7 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_host *host, > SUN6I_DSI_CMD_CTL_TX_FLAG); -> =20 +> > switch (msg->type) { > + case MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM: > case MIPI_DSI_DCS_SHORT_WRITE: @@ -28,11 +26,10 @@ t *host, You should order them by alphabetical order. -> ret =3D sun6i_dsi_dcs_write_short(dsi, msg); -> @@ -885,6 +886,8 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_hos= -t *host, +> ret = sun6i_dsi_dcs_write_short(dsi, msg); +> @@ -885,6 +886,8 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_host *host, > } -> =20 +> > default: > + dev_err(dsi->dev, "unsupported message type 0x%02x\n", > + msg->type); @@ -41,7 +38,7 @@ And this isn't an error check. Maxime ---=20 +-- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com diff --git a/a/content_digest b/N1/content_digest index e0574ce..2cd6737 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -29,24 +29,22 @@ "> share similar way to process command sequence in DSI block so\n" "> add generic write 2 param transfer type macro so-that the panels\n" "> which are requesting similar transfer type may process properly.\n" - ">=20\n" + "> \n" "> Also added error check for unsupporting transfer types this make\n" "> debugging easy for new transfer types.\n" - ">=20\n" + "> \n" "> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>\n" "> ---\n" "> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 3 +++\n" "> 1 file changed, 3 insertions(+)\n" - ">=20\n" - "> diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun=\n" - "4i/sun6i_mipi_dsi.c\n" + "> \n" + "> diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c\n" "> index 156b371243c6..1c7e42015645 100644\n" "> --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c\n" "> +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c\n" - "> @@ -869,6 +869,7 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_hos=\n" - "t *host,\n" + "> @@ -869,6 +869,7 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_host *host,\n" "> \t\t SUN6I_DSI_CMD_CTL_TX_FLAG);\n" - "> =20\n" + "> \n" "> \tswitch (msg->type) {\n" "> +\tcase MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM:\n" "> \tcase MIPI_DSI_DCS_SHORT_WRITE:\n" @@ -54,11 +52,10 @@ "\n" "You should order them by alphabetical order.\n" "\n" - "> \t\tret =3D sun6i_dsi_dcs_write_short(dsi, msg);\n" - "> @@ -885,6 +886,8 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_hos=\n" - "t *host,\n" + "> \t\tret = sun6i_dsi_dcs_write_short(dsi, msg);\n" + "> @@ -885,6 +886,8 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_host *host,\n" "> \t\t}\n" - "> =20\n" + "> \n" "> \tdefault:\n" "> +\t\tdev_err(dsi->dev, \"unsupported message type 0x%02x\\n\",\n" "> +\t\t\tmsg->type);\n" @@ -67,9 +64,9 @@ "\n" "Maxime\n" "\n" - "--=20\n" + "-- \n" "Maxime Ripard, Bootlin\n" "Embedded Linux and Kernel engineering\n" https://bootlin.com -4390aa076bd7d3f225fb0a21cf36f83cad2a8621c495144ebba7abc3126888b1 +fb56ecbe254eb24eaf36548049173ad608c816525c9bec5bd1985a68086d34ff
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox