From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B501BC65BA7 for ; Fri, 5 Oct 2018 15:31:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8543920834 for ; Fri, 5 Oct 2018 15:31:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8543920834 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-clk-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728595AbeJEWaS (ORCPT ); Fri, 5 Oct 2018 18:30:18 -0400 Received: from mail.bootlin.com ([62.4.15.54]:49841 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726082AbeJEWaS (ORCPT ); Fri, 5 Oct 2018 18:30:18 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id DD8E52074F; Fri, 5 Oct 2018 17:31:03 +0200 (CEST) Received: from localhost (AAubervilliers-681-1-28-153.w90-88.abo.wanadoo.fr [90.88.148.153]) by mail.bootlin.com (Postfix) with ESMTPSA id AF60520734; Fri, 5 Oct 2018 17:31:03 +0200 (CEST) Date: Fri, 5 Oct 2018 17:31:04 +0200 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel , Michael Turquette , Stephen Boyd , linux-clk , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi Subject: Re: [PATCH 12/12] arm64: dts: allwinner: bananapi-m64: Bananapi S070WV20-CT16 DSI panel Message-ID: <20181005153104.xxv5vxinvawz3hic@flea> References: <20180927114850.24565-1-jagan@amarulasolutions.com> <20180927114850.24565-13-jagan@amarulasolutions.com> <20180927171747.wqdt5eiwktyyoefz@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xdzysu2lcfowgjtf" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org --xdzysu2lcfowgjtf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 04, 2018 at 09:33:59PM +0530, Jagan Teki wrote: > On Thu, Sep 27, 2018 at 10:47 PM Maxime Ripard > wrote: > > > > On Thu, Sep 27, 2018 at 05:18:50PM +0530, Jagan Teki wrote: > > > This patch add support for Bananapi S070WV20-CT16 DSI panel to > > > BPI-M64 board. > > > > > > DSI panel connected via board DSI port with, > > > - DC1SW as AVDD supply > > > - DCDC1 as DVDD supply > > > - PD6 gpio for reset pin > > > - PD5 gpio for backlight enable pin > > > - PD7 gpio for backlight vdd supply > > > > > > Signed-off-by: Jagan Teki > > > --- > > > .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 42 +++++++++++++++++= ++ > > > 1 file changed, 42 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dt= s b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > > > index ef1c90401bb2..c0be949be68d 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > > > @@ -45,6 +45,7 @@ > > > #include "sun50i-a64.dtsi" > > > > > > #include > > > +#include > > > > > > / { > > > model =3D "BananaPi-M64"; > > > @@ -56,6 +57,24 @@ > > > serial1 =3D &uart1; > > > }; > > > > > > + vdd_bl: regulator@0 { > > > + compatible =3D "regulator-fixed"; > > > + regulator-name =3D "bl-3v3"; > > > + regulator-min-microvolt =3D <3300000>; > > > + regulator-max-microvolt =3D <3300000>; > > > + gpio =3D <&pio 3 7 GPIO_ACTIVE_HIGH>; /* PD7 */ > > > + enable-active-high; > > > + }; > > > + > > > + backlight_dsi: backlight-dsi { > > > + compatible =3D "pwm-backlight"; > > > + pwms =3D <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; > > > + brightness-levels =3D <0 10 20 30 40 50 60 70 80 90 100= >; > > > > The brightness levels should be increasing linearly from a user point > > of view. Usually, with a PWM backlight, a quadratic rule works much > > better. >=20 > Does that mean, 0 40 80 ... No, that means 1 2 4 8 16 32 etc.. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --xdzysu2lcfowgjtf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlu3g7cACgkQ0rTAlCFN r3Sw9g/+J1ltTpyEpyVxRuutEOOe7lCdxJS7qNYR35GQw7Q66wh+mzC+eaY5D5qK BsBIzsSGMR9cGqQroY/SxahVJlk3dgzsVRQYvekaWIyoiVeMAHEGOtCJ1JH7X10K /y3FfD9Gruj+yuTdbEF1or3tEN8wvFMBNVCUO6Pa6r83jo6J1LKF7cYp3Jt+tbmo mbKwWxpZ1mKfFRxJ44kw6Uz6h96ljeEIscfsiopEjmCPlg94vMAuGRwcYHnvZrqy 5Ig0OSlrdPMVz0PS27dF/JTVTJu+f+FbOP0ZWbXcZylswVWCKCxQjNhmGpYz5xLB lodS+b++sx/hCBVZCWmFJwfJfocMcdRU16bpPgCsMoDSg/3AJIdys9gWob/T0klR LMHTQkCUj9ZpvkIv+Vf211u5KsFlQzay1FnItm5RwfVW8jF7KIF/+PHj99QR3UFu qOx93gUDIrUWQv96/wnPyEmEnqjRH8sw5EIk0XzcZTyRQ9nUW9npv99Rn8dOeoXc cwsNNlIitQqjIIT0URmiOnRbz98hEggqxzIusMUj3w37IzHqdTGHdJlhWkK+UCHO j/Htn8yUs914Y+/y6W5NLH/3cW3epsblGwQxn8B0/TjLWSIEfxB1n0KH6phKRmgg 3Dm1x2T6MkSEGEDfv+J4/K1YuDLkguI8ICSQ+le3PbI+XtikdmA= =lZdS -----END PGP SIGNATURE----- --xdzysu2lcfowgjtf--