From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A258C32788 for ; Thu, 11 Oct 2018 09:32:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB9112098A for ; Thu, 11 Oct 2018 09:32:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="TyPra1Nd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB9112098A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-clk-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727628AbeJKQ7L (ORCPT ); Thu, 11 Oct 2018 12:59:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:50714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726695AbeJKQ7L (ORCPT ); Thu, 11 Oct 2018 12:59:11 -0400 Received: from localhost (unknown [122.167.117.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9CDA62087A; Thu, 11 Oct 2018 09:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539250363; bh=ntOYra940UMADE0h/c6+oUh6BpAHXqaB2dtaon1xMk4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TyPra1Ndqz8YH2UwHctbR2iPg6+tmR6kS+mswOola40EYxqcs1skUIZUpXHNtB6mU CPa7ST4gj9yiPuULycw55BfyNfFcoURMVjo4qgdhojzy6ubefTjrtM2PA+vmhncOry uh99iurxj0MeCx/3kvzU6LsBMtwwv6+QAqTokpyA= Date: Thu, 11 Oct 2018 15:02:34 +0530 From: Vinod To: Stephen Boyd Cc: Michael Turquette , Shefali Jain , Rob Herring , Mark Rutland , Andy Gross , David Brown , Bjorn Andersson , Anu Ramanathan , Taniya Das , "open list:COMMON CLK FRAMEWORK" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "open list:ARM/QUALCOMM SUPPORT" , "open list:ARM/QUALCOMM SUPPORT" Subject: Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404 Message-ID: <20181011093234.GA2400@vkoul-mobl> References: <20180921185936.9590-1-vkoul@kernel.org> <20180921185936.9590-2-vkoul@kernel.org> <153841434099.119890.3912925112860077471@swboyd.mtv.corp.google.com> <20181003062103.GN19792@vkoul-mobl> <153896630923.119890.17169150168947487135@swboyd.mtv.corp.google.com> <20181008035144.GD2372@vkoul-mobl> <153924236897.5275.4858274509208170603@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <153924236897.5275.4858274509208170603@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 11-10-18, 00:19, Stephen Boyd wrote: > Quoting Vinod (2018-10-07 20:51:44) > > On 07-10-18, 19:38, Stephen Boyd wrote: > > > Quoting Vinod (2018-10-02 23:21:03) > > > > Hi Stephen, > > > > > > > > Thanks for the comments, > > > > > > > > On 01-10-18, 10:19, Stephen Boyd wrote: > > > > > Quoting Vinod Koul (2018-09-21 11:59:36) > > > > > > From: Shefali Jain > > > > > > > > > > > > Add the clocks supported in global clock controller which clock the > > > > > > peripherals like BLSPs, SDCC, USB, MDSS etc. Register all the clocks > > > > > > to the clock framework for the clients to be able to request for them. > > > > > > > > > > > > Signed-off-by: Shefali Jain > > > > > > Signed-off-by: Taniya Das > > > > > > Co-developed-by: Taniya Das > > > > > > Signed-off-by: Anu Ramanathan > > > > > > [rebase and tidyup for upstream] > > > > > > > > > > Who did the tidying? > > > > > > > > both of us :) > > > > > > OK, please add the username of both people per the kernel sign off > > > standards. > > > > > > > > > Signed-off-by: Bjorn Andersson > > > > > > Signed-off-by: Vinod Koul > > > > Sorry not sure I understand, Bjorn and me did cleanup and we signed-off > > per process, did I miss something? > > I mean doing something like: > > [bjorn.andersson@linaro.org: Clean and tidy] > Signed-off-by: Bjorn Andersson > [vkoul@kernel.org: Clean and tidy even more] > Signed-off-by: Vinod Koul > > Would be the kernel standard for maintainer tags. Ah I did: [bamse, vkoul: rebase and tidyup for upstream] I can wait for comments if you have for v2 and update and send v3 then? > > > > > > > > > + [GCC_USB_HS_PHY_CFG_AHB_CLK] = &gcc_usb_hs_phy_cfg_ahb_clk.clkr, > > > > > > + [GCC_USB_HS_SYSTEM_CLK] = &gcc_usb_hs_system_clk.clkr, > > > > > > + [GFX3D_CLK_SRC] = &gfx3d_clk_src.clkr, > > > > > > + [GP1_CLK_SRC] = &gp1_clk_src.clkr, > > > > > > > > > > Why are some of these missing GCC_ prefix? > > > > > > > > will add.. > > > > > > Thanks! > > > > Btw Taniya also commented on this, do you want this as GCC_ or as per hw > > documentation? > > I don't care. Either way is fine with me. I have used GCC_ :) -- ~Vinod