From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>, Alan Tull <atull@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCH 4/5] clk: fixed-rate: Use devm_of_clk_add_provider
Date: Thu, 1 Nov 2018 15:40:43 +0100 [thread overview]
Message-ID: <20181101144044.11495-5-ricardo.ribalda@gmail.com> (raw)
In-Reply-To: <20181101144044.11495-1-ricardo.ribalda@gmail.com>
Use devm_clk_add_provider. It will take care of clk un-registering.
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/clk/clk-fixed-rate.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
index 6d6475c32ee5..2678b7bd68ac 100644
--- a/drivers/clk/clk-fixed-rate.c
+++ b/drivers/clk/clk-fixed-rate.c
@@ -158,7 +158,8 @@ void clk_hw_unregister_fixed_rate(struct clk_hw *hw)
EXPORT_SYMBOL_GPL(clk_hw_unregister_fixed_rate);
#ifdef CONFIG_OF
-static struct clk *_of_fixed_clk_setup(struct device_node *node)
+static struct clk *_of_fixed_clk_setup(struct device *dev,
+ struct device_node *node)
{
struct clk *clk;
const char *clk_name = node->name;
@@ -173,12 +174,16 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node)
of_property_read_string(node, "clock-output-names", &clk_name);
- clk = clk_register_fixed_rate_with_accuracy(NULL, clk_name, NULL,
+ clk = clk_register_fixed_rate_with_accuracy(dev, clk_name, NULL,
0, rate, accuracy);
if (IS_ERR(clk))
return clk;
- ret = of_clk_add_provider(node, of_clk_src_simple_get, clk);
+ if (dev)
+ ret = devm_of_clk_add_provider(dev, of_clk_src_simple_get, clk);
+ else
+ ret = of_clk_add_provider(node, of_clk_src_simple_get, clk);
+
if (ret) {
clk_unregister(clk);
return ERR_PTR(ret);
@@ -192,7 +197,7 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node)
*/
void __init of_fixed_clk_setup(struct device_node *node)
{
- _of_fixed_clk_setup(node);
+ _of_fixed_clk_setup(NULL, node);
}
CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);
@@ -200,7 +205,6 @@ static int of_fixed_clk_remove(struct platform_device *pdev)
{
struct clk *clk = platform_get_drvdata(pdev);
- of_clk_del_provider(pdev->dev.of_node);
clk_unregister_fixed_rate(clk);
return 0;
@@ -214,7 +218,7 @@ static int of_fixed_clk_probe(struct platform_device *pdev)
* This function is not executed when of_fixed_clk_setup
* succeeded.
*/
- clk = _of_fixed_clk_setup(pdev->dev.of_node);
+ clk = _of_fixed_clk_setup(&pdev->dev, pdev->dev.of_node);
if (IS_ERR(clk))
return PTR_ERR(clk);
--
2.19.1
next prev parent reply other threads:[~2018-11-01 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 14:40 [PATCH 0/5] Implement devm_of_clk_add_provider Ricardo Ribalda Delgado
2018-11-01 14:40 ` [PATCH 1/5] clk: Refactor of_clk_add_provider and of_clk_add_hw_provider Ricardo Ribalda Delgado
2018-11-01 14:40 ` [PATCH 2/5] clk: Create devm_of_clk_add_provider Ricardo Ribalda Delgado
2018-11-01 14:40 ` [PATCH 3/5] clk: fixed-factor: Use devm_of_clk_add_provider Ricardo Ribalda Delgado
2018-11-01 14:40 ` Ricardo Ribalda Delgado [this message]
2018-11-01 14:40 ` [PATCH 5/5] clk: gpio: " Ricardo Ribalda Delgado
2018-11-01 23:35 ` [PATCH 0/5] Implement devm_of_clk_add_provider Stephen Boyd
2018-11-02 6:54 ` Ricardo Ribalda Delgado
2018-11-02 16:05 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101144044.11495-5-ricardo.ribalda@gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=atull@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox