From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 218B7C43441 for ; Tue, 13 Nov 2018 08:28:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC6BA2245E for ; Tue, 13 Nov 2018 08:28:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="HG+0/S7o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC6BA2245E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-clk-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731125AbeKMSZb (ORCPT ); Tue, 13 Nov 2018 13:25:31 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:40382 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731063AbeKMSZb (ORCPT ); Tue, 13 Nov 2018 13:25:31 -0500 Received: by mail-ed1-f67.google.com with SMTP id d3so9054581edx.7 for ; Tue, 13 Nov 2018 00:28:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=wDHNhd9DUBB7/H+seffFiEBFBEGqlwLGeOpo+/qHkaY=; b=HG+0/S7oKgQrVpWYlK+FBHnv5AQGllwlAE5aEZQ+G5XA33tT+9hWiaRecKkFSKqFJe pQD7RfaBQbQAkFPsYKyNTIPvUvpVZwD6RBPbSMvZvdUhj/AkYBeQbZJ7jB3rhINSVcdb dZ6+44b8CHNylvp6ImtveRiCKCTgFyhX0f81w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=wDHNhd9DUBB7/H+seffFiEBFBEGqlwLGeOpo+/qHkaY=; b=Isaa7We90jfGo5mD4XG3VdAw7FP4SEU77pKSGDGTkHYH8C22EsVcvNjrgOa0geyyVF c6ISgJ0yMxWvJ2Msg1T55KMUJujLDyfkSrAu/u70DT49kCd5OOCTjn+Os8iiCLd3ceeJ GLPhxyCT0Rcm2xwWpn0Dyi0UA0P3IcKJJLFC2efDDrg+32T44BcpS5NDTxk6HChJEFqM bG6lJLEvCAoNAZ6gIksVcNeXmWNxqYXFXYR86DVjPxKf0sDCs5wHonG4UnuupzuZSRFH RaS0zdBQwysQjeAG4HrJiL8OW/cPCaDVsmU5HCdn5+fF66wVlzFbYJHBFFT8JTZ8KR/G S+JQ== X-Gm-Message-State: AGRZ1gJ7RoWST5pCuK7lH7ziQIpen4PImHmOI5u2lLVuac6rSzqhkqB/ L+1i+uGZZDWlrCzfzTzMo83tcA== X-Google-Smtp-Source: AJdET5dtIZdqJmANZAQrFbi5xFHdMkfAlXdno0ZCMZZvpL82FrMyU/GewKQJClznRbNOIEzWBrgQ2w== X-Received: by 2002:a50:f10b:: with SMTP id w11mr12011382edl.0.1542097708815; Tue, 13 Nov 2018 00:28:28 -0800 (PST) Received: from dell ([2.31.167.205]) by smtp.gmail.com with ESMTPSA id d6-v6sm5106300edl.61.2018.11.13.00.28.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Nov 2018 00:28:28 -0800 (PST) Date: Tue, 13 Nov 2018 08:28:25 +0000 From: Lee Jones To: Charles Keepax Cc: mturquette@baylibre.com, sboyd@kernel.org, broonie@kernel.org, linus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v4 3/6] mfd: lochnagar: Add initial binding documentation Message-ID: <20181113082825.GB3513@dell> References: <20181108101405.14062-1-ckeepax@opensource.cirrus.com> <20181108101405.14062-4-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181108101405.14062-4-ckeepax@opensource.cirrus.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, 08 Nov 2018, Charles Keepax wrote: > Lochnagar is an evaluation and development board for Cirrus > Logic Smart CODEC and Amp devices. It allows the connection of > most Cirrus Logic devices on mini-cards, as well as allowing > connection of various application processor systems to provide a > full evaluation platform. This driver supports the board > controller chip on the Lochnagar board. > > Signed-off-by: Charles Keepax > --- > > I have dropped Rob and Stephen's Acks from this patch on > account of the scale of the changes since v3. > > Changes since v3: > - Split the binding up into separate parts for the individual subsystems > - Added documentation for the fixed clocks that are done through DT > > Thanks, > Charles > > .../devicetree/bindings/clock/cirrus,lochnagar.txt | 89 +++++++++++++ > .../devicetree/bindings/mfd/cirrus,lochnagar.txt | 70 ++++++++++ I think these should all be seperate patches. Code looks okay to me though. For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog