Re: [PATCH v5 03/12] clk: mediatek: mt8173: switch mmsys to platform device probing

Matthias Brugger
2019-11-04T11:14:16Z

On 31/10/2019 05:17, Hsin-Yi Wang wrote:
> On Fri, Nov 16, 2018 at 12:54 PM <matthias.bgg@kernel.org> wrote:
>>
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> Switch probing for the MMSYS to support invocation to a
>> plain paltform device. The driver will be probed by the DRM subsystem.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>> ---
>
>> +
>> +static struct platform_driver clk_mt8173_mm_drv = {
>> + .probe = mtk_mmsys_probe,
>> + .probe = mtk_mmsys_remove,
> Should be .remove?
>

Yes, definitely.

>> + .driver = {
>> + .name = "clk-mt8173-mm",
>> + },
>> +};
>> +module_platform_driver(clk_mt8173_mm_drv);
>>
>> static void __init mtk_vdecsys_init(struct device_node *node)
>> {