From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jordan Crouse <jcrouse@codeaurora.org>
Cc: sboyd@kernel.org, mturquette@baylibre.com, andy.gross@linaro.org,
david.brown@linaro.org, rnayak@codeaurora.org,
okukatla@codeaurora.org, tdas@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: qcom: gdsc: Don't override existing gdsc pd functions
Date: Wed, 28 Nov 2018 16:09:38 -0800 [thread overview]
Message-ID: <20181129000938.GH24969@minitux> (raw)
In-Reply-To: <20181126165416.32519-2-jcrouse@codeaurora.org>
On Mon 26 Nov 08:54 PST 2018, Jordan Crouse wrote:
> In extreme cases an individual gdsc may wish to override the
> power domain enable or disable callback functions for their own
> purposes. Only set the generic gdsc callback if the function pointers
> are not already set.
>
> Acked-by: Rajendra Nayak <rnayak@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> ---
> drivers/clk/qcom/gdsc.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c
> index a077133c7ce3..dd63aa36b092 100644
> --- a/drivers/clk/qcom/gdsc.c
> +++ b/drivers/clk/qcom/gdsc.c
> @@ -350,8 +350,10 @@ static int gdsc_init(struct gdsc *sc)
> else
> gdsc_clear_mem_on(sc);
>
> - sc->pd.power_off = gdsc_disable;
> - sc->pd.power_on = gdsc_enable;
> + if (!sc->pd.power_off)
> + sc->pd.power_off = gdsc_disable;
> + if (!sc->pd.power_on)
> + sc->pd.power_on = gdsc_enable;
> pm_genpd_init(&sc->pd, NULL, !on);
>
> return 0;
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-11-29 0:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 16:54 [PATCH 0/2] clk: qcom: Jordan Crouse
2018-11-26 16:54 ` [PATCH 1/2] clk: qcom: gdsc: Don't override existing gdsc pd functions Jordan Crouse
2018-11-29 0:09 ` Bjorn Andersson [this message]
2018-11-26 16:54 ` [PATCH 2/2] clk: qcom: Add a dummy enable function for GX gdsc Jordan Crouse
2018-11-29 0:11 ` Bjorn Andersson
-- strict thread matches above, loose matches on Subject: below --
2018-11-26 17:20 [PATCH v2 0/2] clk: qcom: Support special behavior for SDM845 gpucc Jordan Crouse
2018-11-26 17:20 ` [PATCH 1/2] clk: qcom: gdsc: Don't override existing gdsc pd functions Jordan Crouse
2018-11-28 0:54 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129000938.GH24969@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=okukatla@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).