From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
Amit Kucheria <amit.kucheria@linaro.org>
Subject: Re: [PATCH 2/3] clk: qcom: gcc-msm8998: Disable halt check of UFS clocks
Date: Thu, 29 Nov 2018 23:27:25 -0800 [thread overview]
Message-ID: <20181130072725.GH5278@tuxbook-pro> (raw)
In-Reply-To: <154356160607.88331.15203631970252933137@swboyd.mtv.corp.google.com>
On Thu 29 Nov 23:06 PST 2018, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2018-11-29 22:52:58)
> > Drop the halt check of the UFS symbol clocks, in accordance with other
> > platforms. This makes clk_disable_unused() happy and makes it possible
> > to turn the clocks on again without an error.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Someone was supposed to figure out why we needed to SKIP here instead of
> doing things in the proper order. Is anyone attempting to figure that
> out?
>
I'm not aware of any such efforts, but looping in Vivek here.
I would be happy to revert this change in 8996, 8998 and 845 once such
fix arrives. But as this is needed to make progress on getting UFS up on
8998 it would be nice to get it merged for now...
Regards,
Bjorn
next prev parent reply other threads:[~2018-11-30 7:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 6:52 [PATCH 0/3] clk: qcom: gcc-msm8998: Fixes and clkref clocks Bjorn Andersson
2018-11-30 6:52 ` [PATCH 1/3] clk: qcom: gcc-msm8998: Mark hmss_dvm and lpass_at critical Bjorn Andersson
2018-11-30 7:05 ` Stephen Boyd
2018-11-30 7:24 ` Bjorn Andersson
2018-11-30 8:12 ` Stephen Boyd
2018-11-30 9:23 ` Marc Gonzalez
2018-11-30 15:39 ` Jeffrey Hugo
2018-11-30 6:52 ` [PATCH 2/3] clk: qcom: gcc-msm8998: Disable halt check of UFS clocks Bjorn Andersson
2018-11-30 7:06 ` Stephen Boyd
2018-11-30 7:27 ` Bjorn Andersson [this message]
2018-11-30 8:13 ` Stephen Boyd
2018-11-30 10:55 ` Marc Gonzalez
2018-11-30 13:08 ` Marc Gonzalez
2018-11-30 6:52 ` [PATCH 3/3] clk: qcom: gcc-msm8998: Add clkref clocks Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130072725.GH5278@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox