From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F12E4C04EBF for ; Mon, 3 Dec 2018 15:55:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB26620848 for ; Mon, 3 Dec 2018 15:55:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="gXbvTPaF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB26620848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-clk-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726654AbeLCPz5 (ORCPT ); Mon, 3 Dec 2018 10:55:57 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:39928 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726560AbeLCPz5 (ORCPT ); Mon, 3 Dec 2018 10:55:57 -0500 Received: by mail-pl1-f194.google.com with SMTP id 101so6671817pld.6 for ; Mon, 03 Dec 2018 07:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hvPt/xVlGWX+uMrv7boCKzd2w9RNx+Xk0MMS9Ja4/hA=; b=gXbvTPaFM3HwrOj480Ybjbq5a5D2jqySmh65SKazntlOVnHNCj/SH7/QWeJR0VKT1/ 5r2MFo4QIy5br7G4xo/iU+KP4ilFlvH+lJmLc4DJttv5pD6x/XKdicUnR4ZIGlNvV3yW 58rMWjbme9LjAmjzuNUxCj1YgE9HkpI/XInPk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hvPt/xVlGWX+uMrv7boCKzd2w9RNx+Xk0MMS9Ja4/hA=; b=NljgiLCFJhxkviX1qqkzB39dx5akeQSXK+/iO35c4W3z3O3FmHItm1nzp3UE9Bniss KvWMcpj4QBucRCFsM3cKQw8flNjoqUR9D0I0Ep/J3FZoU3JdS+ZQK/OHov6y2jOLX8/8 SbtNeyPmyA2ozEBMmDmLNfaSKBLw5ahgvI5vxy3JAj1aQOJXjHvoEcX5rJfvVBxiKSQU 6gOIiOJvTzTENZ4+CKUwOnnDMbXdueO/SvD/IS5DbCPvo3Z5/4Zrjyd/UBliugQV+/Km W188kYAGg5JMqOPWpQLo4dl31Rdio2XwaV29xQWa/1Edv0vMuSrNOGeeFuBmhdovXYEU 2WZA== X-Gm-Message-State: AA+aEWa9IFQ3HhMHTK3KHuHYfEPSMLKNlweySD7H2BD6vL6AMIYNgiSh +NSs/BzObXq9+VzLAJcpYc8Qmw== X-Google-Smtp-Source: AFSGD/VGNvCO5MaFvKvTHWs7JoDP3aEtICzteHkFhU6i96ejLzccvE6HkTvXMLMKxwnUjeDsjVMxIg== X-Received: by 2002:a17:902:365:: with SMTP id 92mr15626894pld.327.1543852553309; Mon, 03 Dec 2018 07:55:53 -0800 (PST) Received: from minitux (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id l3sm23050411pga.92.2018.12.03.07.55.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Dec 2018 07:55:52 -0800 (PST) Date: Mon, 3 Dec 2018 07:55:38 -0800 From: Bjorn Andersson To: Jeffrey Hugo Cc: andy.gross@linaro.org, david.brown@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: qcom: Fix MSM8998 resets Message-ID: <20181203155538.GQ2225@minitux> References: <1543851298-32320-1-git-send-email-jhugo@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1543851298-32320-1-git-send-email-jhugo@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Mon 03 Dec 07:34 PST 2018, Jeffrey Hugo wrote: > The offsets for the defined BCR reset registers does not match the hardware > documentation. Update the values to match the hardware documentation. > Sorry for not spotting this before. > Fixes: b5f5f525c547 (clk: qcom: Add MSM8998 Global Clock Control (GCC) driver) > Signed-off-by: Jeffrey Hugo > --- > drivers/clk/qcom/gcc-msm8998.c | 38 +++++++++++++++++++------------------- > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c > index 9f0ae40..01cc555 100644 > --- a/drivers/clk/qcom/gcc-msm8998.c > +++ b/drivers/clk/qcom/gcc-msm8998.c > @@ -2742,25 +2742,25 @@ enum { > }; > > static const struct qcom_reset_map gcc_msm8998_resets[] = { > - [GCC_BLSP1_QUP1_BCR] = { 0x102400 }, > - [GCC_BLSP1_QUP2_BCR] = { 0x110592 }, > - [GCC_BLSP1_QUP3_BCR] = { 0x118784 }, > - [GCC_BLSP1_QUP4_BCR] = { 0x126976 }, > - [GCC_BLSP1_QUP5_BCR] = { 0x135168 }, > - [GCC_BLSP1_QUP6_BCR] = { 0x143360 }, > - [GCC_BLSP2_QUP1_BCR] = { 0x155648 }, > - [GCC_BLSP2_QUP2_BCR] = { 0x163840 }, > - [GCC_BLSP2_QUP3_BCR] = { 0x172032 }, > - [GCC_BLSP2_QUP4_BCR] = { 0x180224 }, > - [GCC_BLSP2_QUP5_BCR] = { 0x188416 }, > - [GCC_BLSP2_QUP6_BCR] = { 0x196608 }, > - [GCC_PCIE_0_BCR] = { 0x438272 }, > - [GCC_PDM_BCR] = { 0x208896 }, > - [GCC_SDCC2_BCR] = { 0x81920 }, > - [GCC_SDCC4_BCR] = { 0x90112 }, > - [GCC_TSIF_BCR] = { 0x221184 }, > - [GCC_UFS_BCR] = { 0x479232 }, > - [GCC_USB_30_BCR] = { 0x61440 }, > + [GCC_BLSP1_QUP1_BCR] = { 0x19000 }, > + [GCC_BLSP1_QUP2_BCR] = { 0x1b000 }, > + [GCC_BLSP1_QUP3_BCR] = { 0x1d000 }, > + [GCC_BLSP1_QUP4_BCR] = { 0x1f000 }, > + [GCC_BLSP1_QUP5_BCR] = { 0x21000 }, > + [GCC_BLSP1_QUP6_BCR] = { 0x23000 }, > + [GCC_BLSP2_QUP1_BCR] = { 0x26000 }, > + [GCC_BLSP2_QUP2_BCR] = { 0x28000 }, > + [GCC_BLSP2_QUP3_BCR] = { 0x2a000 }, > + [GCC_BLSP2_QUP4_BCR] = { 0x2c000 }, > + [GCC_BLSP2_QUP5_BCR] = { 0x2e000 }, > + [GCC_BLSP2_QUP6_BCR] = { 0x30000 }, > + [GCC_PCIE_0_BCR] = { 0x6c01c }, I find GCC_PCIE_0_BCR at 0x6b000 and then GCC_PCIE_0_PHY_BCR at 0x6c01c. > + [GCC_PDM_BCR] = { 0x33000 }, > + [GCC_SDCC2_BCR] = { 0x14000 }, > + [GCC_SDCC4_BCR] = { 0x16000 }, > + [GCC_TSIF_BCR] = { 0x36000 }, > + [GCC_UFS_BCR] = { 0x75000 }, > + [GCC_USB_30_BCR] = { 0xf000 }, > }; With this updated, you have my Reviewed-by: Bjorn Andersson Regards, Bjorn