Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

Stephen Boyd
2018-11-30T08:54:13Z

Quoting Matti Vaittinen (2018-11-13 03:55:58)
> With MFD devices the clk properties may be contained in MFD (parent) DT
> node. Current devm_of_clk_add_hw_provider assumes the clk is bound to MFD
> subdevice not to MFD device (parent). Add
> devm_of_clk_add_hw_provider_parent to tackle this issue.
>
> Also clkdev registration lacks of managed registration functions and it
> seems few drivers do not drop clkdev lookups at exit. Add
> devm_clk_hw_register_clkdev and devm_clk_release_clkdev to ease lookup
> releasing at exit.

Please split this into clkdev and non-clkdev devm functionality.

>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> Documentation/driver-model/devres.txt | 3 +
> drivers/clk/clk.c | 28 ++++++--
> drivers/clk/clkdev.c | 122 ++++++++++++++++++++++++++--------
> include/linux/clk-provider.h | 11 +++
> include/linux/clkdev.h | 4 ++
> 5 files changed, 136 insertions(+), 32 deletions(-)
>
> diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
> index 43681ca0837f..fac63760b01c 100644
> --- a/Documentation/driver-model/devres.txt
> +++ b/Documentation/driver-model/devres.txt
> @@ -238,6 +238,9 @@ CLOCK
> devm_clk_put()
> devm_clk_hw_register()
> devm_of_clk_add_hw_provider()
> + devm_of_clk_add_parent_hw_provider()
> + devm_clk_hw_register_clkdev()
> + devm_clk_release_clkdev()

The 'release' or non-common functions shouldn't be documented here.

>
> DMA
> dmaenginem_async_device_register()
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index af011974d4ec..9bb921eb90f6 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -3893,12 +3893,12 @@ static void devm_of_clk_release_provider(struct device *dev, void *res)
> of_clk_del_provider(*(struct device_node **)res);
> }
>
> -int devm_of_clk_add_hw_provider(struct device *dev,
> +static int __devm_of_clk_add_hw_provider(struct device *dev,
> struct clk_hw *(*get)(struct of_phandle_args *clkspec,
> void *data),
> - void *data)
> + struct device_node *of_node, void *data)
> {
> - struct device_node **ptr, *np;
> + struct device_node **ptr;
> int ret;
>
> ptr = devres_alloc(devm_of_clk_release_provider, sizeof(*ptr),
> @@ -3906,10 +3906,9 @@ int devm_of_clk_add_hw_provider(struct device *dev,
> if (!ptr)
> return -ENOMEM;
>
> - np = dev->of_node;
> - ret = of_clk_add_hw_provider(np, get, data);
> + *ptr = of_node;
> + ret = of_clk_add_hw_provider(of_node, get, data);
> if (!ret) {
> - *ptr = np;

Why is this moved outside of the if condition? In fact, why isn't just
the first line in this hunk deleted and passed to this function as
struct device_node *np?

> devres_add(dev, ptr);
> } else {
> devres_free(ptr);
> @@ -3917,8 +3916,25 @@ int devm_of_clk_add_hw_provider(struct device *dev,
>
> return ret;
> }

Nitpick: Add a newline here.

> +int devm_of_clk_add_hw_provider(struct device *dev,
> + struct clk_hw *(*get)(struct of_phandle_args *clkspec,
> + void *data),
> + void *data)
> +{
> + return __devm_of_clk_add_hw_provider(dev, get, dev->of_node, data);
> +}
> EXPORT_SYMBOL_GPL(devm_of_clk_add_hw_provider);
>
> +int devm_of_clk_add_parent_hw_provider(struct device *dev,
> + struct clk_hw *(*get)(struct of_phandle_args *clkspec,
> + void *data),
> + void *data)
> +{
> + return __devm_of_clk_add_hw_provider(dev, get, dev->parent->of_node,

I'm wondering if we can somehow auto-detect this in
devm_of_clk_add_hw_provider() by looking for #clock-cells in the node.
If it isn't there, then we go to the parent node and look for a
#clock-cells property there in the DT node for that device. Does that
make sense? Then there isn't any new API and we can attach the lifetime
of the devm registration to the presence of the property indicating this
is a clk controller or not.

> + data);
> +}
> +EXPORT_SYMBOL_GPL(devm_of_clk_add_parent_hw_provider);

Can we get some kernel doc on these functions?

> +
> /**
> * of_clk_del_provider() - Remove a previously registered clock provider
> * @np: Device node pointer associated with clock provider
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index 9ab3db8b3988..f6100b6e06fd 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
[...]
> +
> +/**
> + * devm_clk_release_clkdev - Resource managed clkdev lookup release
> + * @dev: device this lookup is bound
> + * @con_id: connection ID string on device
> + * @dev_id: format string describing device name
> + *
> + * Drop the clkdev lookup created with devm_clk_hw_register_clkdev.
> + * Normally this function will not need to be called and the resource
> + * management code will ensure that the resource is freed.
> + */
> +void devm_clk_release_clkdev(struct device *dev, const char *con_id,
> + const char *dev_id)
> +{
> + struct clk_lookup *cl;
> + int rval;
> +
> + cl = clk_find(dev_id, con_id);
> + WARN_ON(!cl);
> + rval = devres_release(dev, devm_clkdev_release,
> + &devm_clk_match_clkdev, cl);

Nitpick: Drop & on functions taken as pointers.

> + WARN_ON(rval);
> +}
> +EXPORT_SYMBOL(devm_clk_release_clkdev);