From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72569C43387 for ; Wed, 19 Dec 2018 15:50:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BBCB20449 for ; Wed, 19 Dec 2018 15:50:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728680AbeLSPui (ORCPT ); Wed, 19 Dec 2018 10:50:38 -0500 Received: from mail.bootlin.com ([62.4.15.54]:37676 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727594AbeLSPui (ORCPT ); Wed, 19 Dec 2018 10:50:38 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 1B82020A82; Wed, 19 Dec 2018 16:50:36 +0100 (CET) Received: from localhost (aaubervilliers-681-1-38-38.w90-88.abo.wanadoo.fr [90.88.157.38]) by mail.bootlin.com (Postfix) with ESMTPSA id CD38F2037D; Wed, 19 Dec 2018 16:50:25 +0100 (CET) Date: Wed, 19 Dec 2018 16:50:26 +0100 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Michael Turquette , Stephen Boyd , linux-arm-kernel , linux-clk , linux-kernel , dri-devel , Michael Trimarchi , linux-sunxi , linux-amarula@amarulasolutions.com Subject: Re: [PATCH v5 07/17] drm/sun4i: sun6i_mipi_dsi: Refactor vertical video start delay Message-ID: <20181219155026.2mpnmdibs3i6ianh@flea> References: <20181210161729.29720-1-jagan@amarulasolutions.com> <20181210161729.29720-8-jagan@amarulasolutions.com> <20181211164900.wfmkmbrbj3nmlb3h@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pabpp542fin7m244" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org --pabpp542fin7m244 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 11, 2018 at 10:30:08PM +0530, Jagan Teki wrote: > On Tue, Dec 11, 2018 at 10:19 PM Maxime Ripard > wrote: > > > > On Mon, Dec 10, 2018 at 09:47:19PM +0530, Jagan Teki wrote: > > > Video start delay can be computed by subtracting total vertical > > > timing with front porch timing and with adding 1 delay line for TCON. > > > > > > BSP code form BPI-M64-bsp is computing video start delay as > > > (from linux-sunxi/ > > > drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > > > > > > u32 vfp =3D panel->lcd_vt - panel->lcd_y - panel->lcd_vbp; > > > =3D> (panel->lcd_vt) - panel->lcd_y - (panel->lcd_vbp) > > > =3D> (timmings->ver_front_porch + panel->lcd_vbp + panel->lcd_y) > > > - panel->lcd_y - (panel->lcd_vbp) > > > =3D> timmings->ver_front_porch + panel->lcd_vbp + panel->lcd_y > > > - panel->lcd_y - panel->lcd_vbp > > > =3D> timmings->ver_front_porch > > > > > > So, update the start delay computation accordingly. > > > > > > Signed-off-by: Jagan Teki > > > > Even though it's a bit better now on my A33 board and I don't have the > > white stripes on the bottom of the display, there's still some > > flickering with your patches applied. > > > > Bisecting it seems to point at that patch, but reverting it doesn't > > make the issue go away, so it's not really clear which one exactly is > > at fault. > > > > So, just like I asked in your v4, twice, > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/615= 339.html >=20 > I don't know how can I comment here. Not quite clearly understand your > setup, because I have verified 3 different panels from different > vendors one with 2-lane, another with 4-lane and one with video format > and another one is burstmode format. I even verified with the clock > rate and register details. > > Please suggest me, what can look further on this. You had a reason to do these patches in the first place, yet you never mention it anywhere in your commit logs. it would address the first part of my comment. And I can help you nail down whatever is going on here, but I would need the panel datasheet for that. It is my second point. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --pabpp542fin7m244 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXBpowgAKCRDj7w1vZxhR xS5mAPkBvCnKEMqNBzx1jl/H57Y26OfbClwFS5eU5c1rFTUIIwEA6cxvVrxQQtiz TkacBASu5Zw9+olpuqa2tKq8tAcJdw4= =GMM5 -----END PGP SIGNATURE----- --pabpp542fin7m244--