Re: [PATCH] clk: qcom: Add MSM8976/56 Global Clock Controller (GCC) driver

Re: [PATCH] clk: qcom: Add MSM8976/56 Global Clock Controller (GCC) driver

[Rob Herring]

On Sat, Jan 12, 2019 at 04:03:18PM +0100, AngeloGioacchino Del Regno wrote:
> From 50465f2a4454625aac622bb84dbecdeaf5a50904 Mon Sep 17 00:00:00 2001
> From: "Angelo G. Del Regno" <kholk11@gmail.com>
> Date: Sat, 12 Jan 2019 10:52:18 +0100
> Subject: [PATCH] clk: qcom: Add MSM8976/56 Global Clock Controller (GCC)
>  driver

Looks like your patch is corrupted.

> 
> Add support for the global clock controller found on MSM8976
> and MSM8976 SoCs.
> Since the multimedia clocks are actually in the GCC on these
> SoCs, this will allow drivers to probe and control basically
> all the required clocks.
> 
> Signed-off-by: Angelo G. Del Regno <kholk11@gmail.com>
> ---
>  .../devicetree/bindings/clock/qcom,gcc.txt    |    1 +
>  drivers/clk/qcom/Kconfig                      |    8 +
>  drivers/clk/qcom/Makefile                     |    1 +
>  drivers/clk/qcom/gcc-msm8976.c                | 4208 +++++++++++++++++
>  include/dt-bindings/clock/qcom,gcc-msm8976.h  |  293 ++

The binding doc and this header should be in a separate patch.

>  5 files changed, 4511 insertions(+)
>  create mode 100644 drivers/clk/qcom/gcc-msm8976.c
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8976.h

Re: [PATCH] clk: qcom: Add MSM8976/56 Global Clock Controller (GCC) driver

[Stephen Boyd]

Quoting AngeloGioacchino Del Regno (2019-01-12 07:03:18)
> From 50465f2a4454625aac622bb84dbecdeaf5a50904 Mon Sep 17 00:00:00 2001
> From: "Angelo G. Del Regno" <kholk11@gmail.com>
> Date: Sat, 12 Jan 2019 10:52:18 +0100
> Subject: [PATCH] clk: qcom: Add MSM8976/56 Global Clock Controller (GCC)
>  driver
> 
> Add support for the global clock controller found on MSM8976
> and MSM8976 SoCs.
> Since the multimedia clocks are actually in the GCC on these
> SoCs, this will allow drivers to probe and control basically
> all the required clocks.
> 
> Signed-off-by: Angelo G. Del Regno <kholk11@gmail.com>

Are you going to send out DTS bits and provide platform support? I'm not
interested in merging the clk bits and then having to support a driver
that never gets used.

Also, is this copy/pasted from some downstream kernel sources? Would be
good to have a pointer to that so we can compare and see if you've
changed anything.