From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4706C282C0 for ; Fri, 25 Jan 2019 21:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B1F52184C for ; Fri, 25 Jan 2019 21:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728236AbfAYVVf convert rfc822-to-8bit (ORCPT ); Fri, 25 Jan 2019 16:21:35 -0500 Received: from mail.bootlin.com ([62.4.15.54]:33791 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbfAYVVf (ORCPT ); Fri, 25 Jan 2019 16:21:35 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 55484207B2; Fri, 25 Jan 2019 22:21:32 +0100 (CET) Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.bootlin.com (Postfix) with ESMTPSA id 113C620397; Fri, 25 Jan 2019 22:21:32 +0100 (CET) Date: Fri, 25 Jan 2019 22:21:32 +0100 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Michael Turquette , Stephen Boyd , linux-arm-kernel , linux-clk , linux-kernel , dri-devel , Michael Trimarchi , linux-sunxi , linux-amarula@amarulasolutions.com Subject: Re: [PATCH v5 07/17] drm/sun4i: sun6i_mipi_dsi: Refactor vertical video start delay Message-ID: <20190125212132.ea2iq6tsgyawkemx@flea> References: <20190108085829.clianbtjovu3oieq@flea> <20190112164319.whr7gwvl4oux5svz@flea> <20190116191756.ajzzaga43srk77dk@flea> <20190122111118.db7bqppop4basxd7@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, Jan 22, 2019 at 05:21:08PM +0530, Jagan Teki wrote: > On Tue, Jan 22, 2019 at 4:41 PM Maxime Ripard wrote: > > > > On Fri, Jan 18, 2019 at 09:14:19PM +0530, Jagan Teki wrote: > > > On Thu, Jan 17, 2019 at 10:02 AM Jagan Teki wrote: > > > > > > > > On Thu, Jan 17, 2019 at 12:48 AM Maxime Ripard > > > > wrote: > > > > > > > > > > On Sun, Jan 13, 2019 at 01:07:41AM +0530, Jagan Teki wrote: > > > > > > > > > > > Again, I cannot help you without the datasheet for the panels you're > > > > > > > > > > > trying to submit. > > > > > > > > > > > > > > > > > > > > The panel bound with Sitronix ST7701 IC > > > > > > > > > > http://www.startek-lcd.com/res/starteklcd/pdres/201705/20170512144242904.pdf > > > > > > > > > > > > > > > > > > It's the controller, not the panel > > > > > > > > > > > > > > > > As I said before, the datasheet of that panel doesn't have any > > > > > > > > information except electrical characteristics and used IC which is > > > > > > > > ST7701. > > > > > > > > > > > > > > > > I have one more panel, which is from Bananapi, S070WV20-CT16 ICN621 > > > > > > > > please find the attachment for the same. > > > > > > > > > > > > > > > > Here is some more details of the same. > > > > > > > > > > > > > > > > https://github.com/yesnoandor/x300/blob/master/kernel/arch/arm/boot/dts/erobbing/x300/x300.dtsi#L81 > > > > > > > > https://github.com/wxzed/Raspberry_5MIPI_Display/blob/master/I2C_Slave/USER/main.c#L15 > > > > > > > > > > > > > > > > https://github.com/eliot-shao/qcom/blob/master/icn6211_cxn0102/kernel/drivers/video/msm/mdss/mdss_i2c_interface.c#L152 > > > > > > > > matches timings for > > > > > > > > https://github.com/eliot-shao/qcom/blob/master/icn6211_cxn0102/kernel/arch/arm/boot/dts/qcom/dsi-mipi-2-rgb_1280p_video.dtsi#L20 > > > > > > > > > > > > > > > > https://github.com/zestroly/micromat/blob/master/test/raspberry/ICN6211.cpp#L169 > > > > > > > > > > > > > > Where did you get the timings from then? > > > > > > > > > > > > You mean drm_mode timings, the same panel with RGB available in > > > > > > panel-simple[1], and dsi driver in Mailing list[2] and actual DSI > > > > > > sequence commands from BSP[3] > > > > > > > > > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/panel/panel-simple.c?id=7ad8b41cd8f5c2842646d01cdd576663caee04a7 > > > > > > [2] https://patchwork.kernel.org/patch/10680331/ > > > > > > [3] https://github.com/BPI-SINOVOIP/BPI-M64-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp2/disp/lcd/S070WV20_MIPI_RGB.c > > > > > > > > > > So you had no reliable source for the timings then? How do you know if > > > > > all your patches that are timing related are right then? > > > > > > > > I don't understand your point, or may be I confused with many links > > > > that I attached in previous mail. > > > > > > > > 1. Patch for same panel timings are already in Mainline that was > > > > tested on one of the board. [1] > > > > 2. Driver from AW, released bsp from BPI-M64-bsp [3] > > > > > > > > Do you think the above two points are not valid sources? > > > > > > fyi, the panel datasheet attached in above mail has timing information. > > > > Do you have a page number? > > Page 4 > 5.2 Interface Timings Which datasheet are we talking about here? The only one I've seen is the Sitronix IC's and the page 4 is the summary. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com