From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Michael Grzeschik" <m.grzeschik@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] clk: imx5: Fix i.MX50 clock registers
Date: Tue, 19 Mar 2019 15:27:56 +0100 [thread overview]
Message-ID: <20190319142756.GB2095@latitude> (raw)
In-Reply-To: <AM0PR04MB4211990282677EEB9D3928F380400@AM0PR04MB4211.eurprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Tue, Mar 19, 2019 at 02:16:51PM +0000, Aisheng Dong wrote:
> > From: Jonathan Neuschäfer [mailto:j.neuschaefer@gmx.net]
> >
> > There are a few differences between the i.MX50 clock tree and those of
> > i.MX51 and i.MX53 that are not yet handled in clk-imx51-imx53.c.
> > This patch handles the following differences:
> >
> > - i.MX50 does not have a periph_apm clock. Instead, the main bus clock
> > (a.k.a. periph_clk) comes directly from a MUX between pll1_sw,
> > pll2_sw, pll3_sw, and lp_apm.
> > - The MUX bits for esdhc_{a,c,d}_sel are shifted by one bit within
> > CSCMR1.
> >
>
> Can you please split them into two patches?
> Otherwise, the fix seems good to me.
Ok, I'll do that.
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-03-19 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 23:17 [PATCH RESEND] clk: imx5: Fix i.MX50 clock registers Jonathan Neuschäfer
2019-03-19 14:16 ` Aisheng Dong
2019-03-19 14:27 ` Jonathan Neuschäfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319142756.GB2095@latitude \
--to=j.neuschaefer@gmx.net \
--cc=aisheng.dong@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mturquette@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox