From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6935AC43381 for ; Wed, 20 Mar 2019 01:00:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 392FB2175B for ; Wed, 20 Mar 2019 01:00:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uhDTHJWS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727461AbfCTBAI (ORCPT ); Tue, 19 Mar 2019 21:00:08 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:43900 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727330AbfCTBAG (ORCPT ); Tue, 19 Mar 2019 21:00:06 -0400 Received: by mail-ot1-f68.google.com with SMTP id u15so583087otq.10 for ; Tue, 19 Mar 2019 18:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+fxZ2uU+NwwuUdaJPYPM/QmxmGfXVrSJft9hKbdRFIA=; b=uhDTHJWSmXN3/w9s+G0Rt6WYHHAMPyDpKo3Tcu+2SBVp/3T+tfH4VA7wRMaQBwHmbR n32XRB5LzBDoPvf24SBROCU+wesncht86BOFwriGPaiIJrtDsM/LfoS7AGlExyHpI7JP dJ7flJ1yXZaTb8g3x5tbOVYT7676aEFgJxhs4GLbndSo82Ay82LnXEbD9vIEvHzFmXH/ pflBcPp0bprf39yvXE1dBL2EqDvGTa9YRQixD132cdJxrWTuTBbM0uVIlRw+8u1OlQib UD3JqHUgFJ3lFqSnRIO7+QNbonJOpUv+r/KCvLVmbJCmC4GHiq/26qWvtcgU237Ter4E jp6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+fxZ2uU+NwwuUdaJPYPM/QmxmGfXVrSJft9hKbdRFIA=; b=YJXLiLirSQsybvQr4QnlXIy/1c1YEy5L8w0mLZymwxZoiNPPmhZ+YsjS9tyRr2Z3T5 ENwx7gyCCXum7mnVhmCMqZEZyzf5VIr9b5c580yKvYRIwaJp4oa5AZ0+HUbc4+Rnc7Cy lydyxFezL7EDDW2H/6XffbETXT0zbBYi1pJt89DSWlaQqw8bfdkeIpXE5/grOwUl3scb 7JxKVUnqQEOQ/SdSZojWFJdpJES1+e22sVIjukG8R/X+llEGy3gJ/jSo0Kl+pX0dhOmn r82FmYHPcXw0eKf3jO+iFEovt4zy1fsRhXQDJmwRJt2QcsUblcoFfERmoIYb1ZNLiceI qMJQ== X-Gm-Message-State: APjAAAWUEoRFpgX2tQS7PSgX7R62pdofnaeK3CaZl9WAsaRA36Wblwt/ SGmGy9mUHijtmzRIJpFAZJ3rpg== X-Google-Smtp-Source: APXvYqwmUF/Rw9tDjAmb5fvOmBEBxT0pX5rbTBUW02BI62AGiWV81ZlhYeWtuUIkyESLstgUf2qdvg== X-Received: by 2002:a9d:5e14:: with SMTP id d20mr3955968oti.172.1553043605731; Tue, 19 Mar 2019 18:00:05 -0700 (PDT) Received: from leoy-ThinkPad-X240s (li808-42.members.linode.com. [104.237.132.42]) by smtp.gmail.com with ESMTPSA id n5sm151996oih.19.2019.03.19.18.00.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Mar 2019 18:00:04 -0700 (PDT) Date: Wed, 20 Mar 2019 08:59:58 +0800 From: Leo Yan To: Stephen Boyd Cc: Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Zhong Kaihua , John Stultz , Zhangfei Gao Subject: Re: [RESEND PATCH] clk: hi3660: Mark clk_gate_ufs_subsys as critical Message-ID: <20190320005958.GA18687@leoy-ThinkPad-X240s> References: <20190319093148.1909-1-leo.yan@linaro.org> <155302456384.20095.11089482394019450818@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <155302456384.20095.11089482394019450818@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, Mar 19, 2019 at 12:42:43PM -0700, Stephen Boyd wrote: > Quoting Leo Yan (2019-03-19 02:31:48) > > diff --git a/drivers/clk/hisilicon/clk-hi3660.c b/drivers/clk/hisilicon/clk-hi3660.c > > index f40419959656..32ba80181cc6 100644 > > --- a/drivers/clk/hisilicon/clk-hi3660.c > > +++ b/drivers/clk/hisilicon/clk-hi3660.c > > @@ -164,7 +164,7 @@ static const struct hisi_gate_clock hi3660_crgctrl_gate_sep_clks[] = { > > { HI3660_CLK_GATE_ISP_SNCLK2, "clk_gate_isp_snclk2", > > "clk_isp_snclk_mux", CLK_SET_RATE_PARENT, 0x50, 18, 0, }, > > { HI3660_CLK_GATE_UFS_SUBSYS, "clk_gate_ufs_subsys", "clk_div_sysbus", > > - CLK_SET_RATE_PARENT, 0x50, 21, 0, }, > > + CLK_SET_RATE_PARENT|CLK_IS_CRITICAL, 0x50, 21, 0, }, > > Nitpick: Please add space around | and also comment in the code why this > is a critical clk. Will fix it and spin a new patch. Thanks for suggestions, Stephen. > > { HI3660_PCLK_GATE_DSI0, "pclk_gate_dsi0", "clk_div_cfgbus", > > CLK_SET_RATE_PARENT, 0x50, 28, 0, }, > > { HI3660_PCLK_GATE_DSI1, "pclk_gate_dsi1", "clk_div_cfgbus",