From: Tony Lindgren <tony@atomide.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-clk@vger.kernel.org, linux-omap@vger.kernel.org,
sboyd@kernel.org, mturquette@baylibre.com,
Eric Ruei <e-ruei1@ti.com>
Subject: Re: [PATCH 5/6] clk: ti: am33xx: drop idlest polling from gfx clkctrl clock
Date: Thu, 4 Apr 2019 07:06:35 -0700 [thread overview]
Message-ID: <20190404140635.GA49658@atomide.com> (raw)
In-Reply-To: <1554365467-1325-6-git-send-email-t-kristo@ti.com>
Hi,
* Tero Kristo <t-kristo@ti.com> [190404 08:12]:
> From: Eric Ruei <e-ruei1@ti.com>
>
> The GFX modules on AM33xx SoCs have a hardreset line and are controlled
> by a GFX reset line. Any clkctrl enable/disable operations cannot be
> checked for module enabled/disabled status independent of the reset
> operation, and this causes some unwanted timeouts in the kernel and
> unbalanced states for the GFX clocks. These details should be handled
> by the driver integration code itself.
These last two patches should no longer be needed with ti-sysc.
Well, at least based on testing with the earlier reset-simple driver
patch and a test for sgx register access on am335x.
On init we deassert rstctrl if configured and in reset, then enable
clocks, and read the module revision. And the module is ready for child
device driver(s) to probe, and do what they want with the rstctrl via a
reset driver. If no child device driver(s) are configured, ti-sysc will
just put the module rstctrl back to reset using reset driver.
Regards,
Tony
next prev parent reply other threads:[~2019-04-04 14:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 8:11 [PATCH 0/6] clk: ti: a few OMAP clock fixes Tero Kristo
2019-04-04 8:11 ` [PATCH 1/6] clk: ti: export the omap2_clk_is_hw_omap call Tero Kristo
2019-04-25 18:15 ` Stephen Boyd
2019-04-04 8:11 ` [PATCH 2/6] ARM: omap2+: hwmod: drop CLK_IS_BASIC flag usage Tero Kristo
2019-04-04 14:06 ` Tony Lindgren
2019-04-25 18:15 ` Stephen Boyd
2019-04-04 8:11 ` [PATCH 3/6] clk: ti: dra7x: prevent non-existing clkctrl clocks from registering Tero Kristo
2019-04-25 18:15 ` Stephen Boyd
2019-04-04 8:11 ` [PATCH 4/6] clk: ti: dra7: disable the RNG and TIMER12 clkctrl clocks on HS devices Tero Kristo
2019-04-25 18:15 ` Stephen Boyd
2019-04-04 8:11 ` [PATCH 5/6] clk: ti: am33xx: drop idlest polling from gfx clkctrl clock Tero Kristo
2019-04-04 14:06 ` Tony Lindgren [this message]
2019-04-08 5:45 ` Tero Kristo
2019-04-25 17:51 ` Stephen Boyd
2019-04-25 17:56 ` Tony Lindgren
2019-04-04 8:11 ` [PATCH 6/6] clk: ti: am43xx: " Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404140635.GA49658@atomide.com \
--to=tony@atomide.com \
--cc=e-ruei1@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).