From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D22EC004C9 for ; Wed, 1 May 2019 03:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2830720866 for ; Wed, 1 May 2019 03:43:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DWZ3Tyz6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726062AbfEADnP (ORCPT ); Tue, 30 Apr 2019 23:43:15 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:37454 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbfEADnP (ORCPT ); Tue, 30 Apr 2019 23:43:15 -0400 Received: by mail-pg1-f194.google.com with SMTP id e6so7796748pgc.4 for ; Tue, 30 Apr 2019 20:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PZNK8TQA6QxASDcv10s+KmD7Rn3kLnmZaWKpog8pPPs=; b=DWZ3Tyz6M6dt6LbxZV1HGVLIzfXTQEEs+kmUxjPEnVWZ0cnnQ9Yj9SS3WgdMmR93R6 DZwRjmuhrTuWH8lN3NvFeLB1zzh0I5qZonPMKc/g4KHXQE0kD8VHTIsUZVvnjQV4ImrD M93pCPAoXIXaZATvRh6tiKgnW3k0QputsjYvZNOIC0+PSyrC9f4JW84O4LA5SrCgq747 iy29eonVGYCUzyd6Gt4DycC3Z6HmuoTWRU2F2/xq3Kymz+54dIqBqcNEtNPmIXCcR/GM tj3NghJvAHCGxO+mCCE3gEsL6gPDZdDbWy1RZP5y+PCmlT+u2zAJ8B/CpA61L7Pg/bQj Au5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PZNK8TQA6QxASDcv10s+KmD7Rn3kLnmZaWKpog8pPPs=; b=UUbILlc5ELA6mrPHYpulDLVxHqmETkKK7K/v8yt6fKcPsbnI+tCQsWrHiZnMPRlrFa 2zDVIE2shXRjXzZnzWRPE+qSGw2dJr0k1pphqV6HX9+9qCHTCvejkk718E+BCijoWW35 nTrRvCUkdcHgnOqtOJdegogyOkt+V6hO5Z1ZD9CEt7j5DoiuBJ3/RxN+ayL0HE7wGQR+ G9f1TrXPMUwEhexaWTqXEPCrYTlxM3C84rsQCz8rAMb+v0uim0mxIblH3RtKzNehNNyk g/45Pj8jRGyZ0LgMcrwW5yGcvoyqRI7nSa/SHrkS8DGJxb8BmHLLz308yNdeZCFjqc5h I3Sw== X-Gm-Message-State: APjAAAUXmPzIehUQJIaqDW7Kc0EaPF1KAtNhIsLYH03TwKq93ZviJS7K 1+R7yimNh+2GVRZPEjfytWdQ2w== X-Google-Smtp-Source: APXvYqyIzd9mFhheIg0Jy9agsnkv1bpzxwGdFd9FfLoyMeJtZ4BIsJ13C1S1WTPgB7fVpH/TmgKvwg== X-Received: by 2002:a63:6fcf:: with SMTP id k198mr70433161pgc.158.1556682194666; Tue, 30 Apr 2019 20:43:14 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id y3sm15333736pfe.9.2019.04.30.20.43.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Apr 2019 20:43:13 -0700 (PDT) Date: Tue, 30 Apr 2019 20:43:14 -0700 From: Bjorn Andersson To: Jeffrey Hugo Cc: mturquette@baylibre.com, sboyd@kernel.org, agross@kernel.org, marc.w.gonzalez@free.fr, david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 5/6] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Message-ID: <20190501034314.GE2938@tuxbook-pro> References: <1556677404-29194-1-git-send-email-jhugo@codeaurora.org> <1556677642-29428-1-git-send-email-jhugo@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556677642-29428-1-git-send-email-jhugo@codeaurora.org> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue 30 Apr 19:27 PDT 2019, Jeffrey Hugo wrote: > +static const struct of_device_id mmcc_msm8998_match_table[] = { > + { .compatible = "qcom,mmcc-msm8998" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, mmcc_msm8998_match_table); > + > +static int mmcc_msm8998_probe(struct platform_device *pdev) > +{ > + struct regmap *regmap; > + Don't you want to wait for "xo" here as well? > + regmap = qcom_cc_map(pdev, &mmcc_msm8998_desc); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + return qcom_cc_really_probe(pdev, &mmcc_msm8998_desc, regmap); > +} [..] > +MODULE_DESCRIPTION("QCOM MMCC MSM8998 Driver"); > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("platform:mmcc-msm8998"); MODULE_DEVICE_TABLE() will provide the alias for module auto loading, so drop this. Regards, Bjorn