From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Jypq=TV=vger.kernel.org=linux-clk-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 31BB5C04AAF
	for <linux-clk@archiver.kernel.org>; Tue, 21 May 2019 18:57:15 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id ED4F5217F5
	for <linux-clk@archiver.kernel.org>; Tue, 21 May 2019 18:57:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1558465035;
	bh=J3SvV9Z6ze4KO1qrk5eCIQuEcPxibxRj+FZGbkfpocA=;
	h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From;
	b=qzXsL8J+tnWoxP2sn241eBgY4HtIn81J+zYONVpffgPemRBDYtq+OYMhIW3iASKR3
	 etkkwKQsL196gUXh9BcPglDMtiueDshQqwOprT6JXCdKnTKvuZL4GRIi63ejicODcQ
	 /k7iUL1/Da8dCQETtL1wpGNBGLGDt28fHATSNp5k=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728175AbfEUS5O (ORCPT <rfc822;linux-clk@archiver.kernel.org>);
        Tue, 21 May 2019 14:57:14 -0400
Received: from mail.kernel.org ([198.145.29.99]:36048 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727990AbfEUS5O (ORCPT <rfc822;linux-clk@vger.kernel.org>);
        Tue, 21 May 2019 14:57:14 -0400
Received: from kernel.org (unknown [104.132.0.74])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id E24632173C;
        Tue, 21 May 2019 18:57:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1558465034;
        bh=J3SvV9Z6ze4KO1qrk5eCIQuEcPxibxRj+FZGbkfpocA=;
        h=In-Reply-To:References:Subject:From:Cc:To:Date:From;
        b=Oau2tag3j1+euW2LzKD4Ol6kN5wOcs5uFAMg0eHY2vMIcOpJWlnsidbUWMnNpxsf0
         NavnvkMXidxd7p7djnThZ2rM8w0fJRswbcPmfsP6SghByEXT55MkfJWjtdsDwFEB1U
         Goy91eZ2WMoo+vWsFLxaKOiV1TnudmNmxQSnXhyw=
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CAMz4kuLjOjKGXn7QtOO5Gizo-FZ7CDf2SiczTNPwDgjAKzm2pw@mail.gmail.com>
References: <20190521060952.2949-1-zhang.chunyan@linaro.org> <20190521060952.2949-2-zhang.chunyan@linaro.org> <CAMz4kuLjOjKGXn7QtOO5Gizo-FZ7CDf2SiczTNPwDgjAKzm2pw@mail.gmail.com>
Subject: Re: [PATCH 1/2] clk: sprd: Switch from of_iomap() to devm_ioremap_resource()
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-clk@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>
To:     Baolin Wang <baolin.wang@linaro.org>,
        Chunyan Zhang <zhang.chunyan@linaro.org>
User-Agent: alot/0.8.1
Date:   Tue, 21 May 2019 11:57:13 -0700
Message-Id: <20190521185713.E24632173C@mail.kernel.org>
Sender: linux-clk-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-clk.vger.kernel.org>
X-Mailing-List: linux-clk@vger.kernel.org

Quoting Baolin Wang (2019-05-20 23:38:03)
> On Tue, 21 May 2019 at 14:15, Chunyan Zhang <zhang.chunyan@linaro.org> wr=
ote:
> >                                                &sprdclk_regmap_config);
> > -               if (IS_ERR_OR_NULL(regmap)) {
> > +               if (IS_ERR(regmap)) {
>=20
> You did not mention this fix in your commit message, and it's better
> to move into one separate patch.
>=20

Please resend with it split out.