From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 515D1C31E46 for ; Wed, 12 Jun 2019 05:10:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 278DF20874 for ; Wed, 12 Jun 2019 05:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560316235; bh=nNjKAxSLRS5Wjiv8q+eu2ijlG5c33+pSJg4RaD8PxrA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uLnmr9TeCSpu/55dOsY+o4rdO7XrCHLSieRo58wa6gRHC5swxq+XvwgEpB8UOOblr RjObRD+H3HiHu2Yj1+8z1/bVOb0RnUsYYzvXdj7RTHUeYic7ATx2fwyZpZCEPu465J c9VhS4EQe5CGTZSSZpGfIDp8rXVdT0GlFXRL0phE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730526AbfFLFKe (ORCPT ); Wed, 12 Jun 2019 01:10:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:51250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbfFLFKe (ORCPT ); Wed, 12 Jun 2019 01:10:34 -0400 Received: from localhost (unknown [106.200.205.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 174A32086A; Wed, 12 Jun 2019 05:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560316233; bh=nNjKAxSLRS5Wjiv8q+eu2ijlG5c33+pSJg4RaD8PxrA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BIui0OQqALdAHPyilX/7/gKaWBcm80sNz4iluadBIGiCO4PvyOxQUogUIMybCxNDO ymaLV5apKyngtuMFhzPRcMSFRTaYsf+QNJXppTCr34BfMpHMk01Cr1YblkhlpOCAhu R1m6hdfRTBroOOGyOFQ2qAXwNsFOrzWsXkQDgNb4= Date: Wed, 12 Jun 2019 10:37:25 +0530 From: Vinod Koul To: Stephen Boyd Cc: Rob Herring , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Deepak Katragadda , Andy Gross , David Brown , Michael Turquette , Mark Rutland , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Taniya Das Subject: Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for SM8150 Message-ID: <20190612050725.GA9160@vkoul-mobl.Dlink> References: <20190607101234.30449-1-vkoul@kernel.org> <20190607101234.30449-2-vkoul@kernel.org> <20190607174353.31EDA208C3@mail.kernel.org> <20190608091537.GG9160@vkoul-mobl.Dlink> <20190610150827.607F6207E0@mail.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190610150827.607F6207E0@mail.kernel.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 10-06-19, 08:08, Stephen Boyd wrote: > Quoting Vinod Koul (2019-06-08 02:15:37) > > On 07-06-19, 10:43, Stephen Boyd wrote: > > > Quoting Vinod Koul (2019-06-07 03:12:34) > > > > diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c > > > > new file mode 100644 > > > > index 000000000000..1cbc884444c9 > > > > --- /dev/null > > > > +++ b/drivers/clk/qcom/gcc-sm8150.c > > > > +static const struct parent_map gcc_parent_map_0[] = { > > > > + { P_BI_TCXO, 0 }, > > > > + { P_GPLL0_OUT_MAIN, 1 }, > > > > + { P_GPLL0_OUT_EVEN, 6 }, > > > > + { P_CORE_BI_PLL_TEST_SE, 7 }, > > > > +}; > > > > + > > > > +static const char * const gcc_parent_names_0[] = { > > > > > > We have a new way of specifying clk parents now. Can you use that > > > instead of using strings everywhere? > > > > Okay I will update, any pointers on new implementation I can look up? > > > > Not really yet. Chen-Yu is working on the Allwinner driver > (drivers/clk/sunxi-ng/) and some work from Jeff for MSM8998 is on the > list that you can look at. Thanks for the pointer, I have done the conversion and will post the update in v2 -- ~Vinod