From: Stephen Boyd <sboyd@kernel.org>
To: JC Kuo <jckuo@nvidia.com>,
jonathanh@nvidia.com, linux-clk@vger.kernel.org,
linux-tegra@vger.kernel.org, pdeschrijver@nvidia.com,
thierry.reding@gmail.com
Cc: JC Kuo <jckuo@nvidia.com>
Subject: Re: [PATCH] clk: tegra210: fix PLLU and PLLU_OUT1
Date: Tue, 25 Jun 2019 16:08:47 -0700 [thread overview]
Message-ID: <20190625230848.C28CB205ED@mail.kernel.org> (raw)
In-Reply-To: <20190612031434.10055-1-jckuo@nvidia.com>
Quoting JC Kuo (2019-06-11 20:14:34)
> Full-speed and low-speed USB devices do not work with Tegra210
> platforms because of incorrect PLLU/PLLU_OUT1 clock settings.
>
> When full-speed device is connected:
> [ 14.059886] usb 1-3: new full-speed USB device number 2 using tegra-xusb
> [ 14.196295] usb 1-3: device descriptor read/64, error -71
> [ 14.436311] usb 1-3: device descriptor read/64, error -71
> [ 14.675749] usb 1-3: new full-speed USB device number 3 using tegra-xusb
> [ 14.812335] usb 1-3: device descriptor read/64, error -71
> [ 15.052316] usb 1-3: device descriptor read/64, error -71
> [ 15.164799] usb usb1-port3: attempt power cycle
>
> When low-speed device is connected:
> [ 37.610949] usb usb1-port3: Cannot enable. Maybe the USB cable is bad?
> [ 38.557376] usb usb1-port3: Cannot enable. Maybe the USB cable is bad?
> [ 38.564977] usb usb1-port3: attempt power cycle
>
> This commit fixes the issue by:
> 1. initializing PLLU_OUT1 before initializing XUSB_FS_SRC clock
> because PLLU_OUT1 is parent of XUSB_FS_SRC.
> 2. changing PLLU post-divider to /2 (DIVP=1) according to Technical
> Reference Manual.
>
> Fixes: e745f992cf4b ("clk: tegra: Rework pll_u")
> Signed-off-by: JC Kuo <jckuo@nvidia.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2019-06-25 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 3:14 [PATCH] clk: tegra210: fix PLLU and PLLU_OUT1 JC Kuo
2019-06-13 10:59 ` Peter De Schrijver
2019-06-25 23:08 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625230848.C28CB205ED@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).