From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7A9C7618F for ; Mon, 22 Jul 2019 21:31:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F4EB2199C for ; Mon, 22 Jul 2019 21:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563831118; bh=6+/sxagahL+li6jU6ojcB6SqYd6K9O6P+akg/i4q2+0=; h=In-Reply-To:References:Subject:To:Cc:From:Date:List-ID:From; b=ZAGJY5dHytktGHqRBBcifKJZsePP7/NHjne6sHdUJYQsTxuI2r/3/QrnutlhS3GeY CEUp9UfqlDRzA0AvQ+f5bz+FD9WwO9t57J8abf1yyj0u06P8uLaHkJsEgHarllpDcT J4xyNuw/k/abSXWzV21FqtvVSe2qUkqG33pblMbM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730980AbfGVVb5 (ORCPT ); Mon, 22 Jul 2019 17:31:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:38846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728016AbfGVVb5 (ORCPT ); Mon, 22 Jul 2019 17:31:57 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8829E21900; Mon, 22 Jul 2019 21:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563831116; bh=6+/sxagahL+li6jU6ojcB6SqYd6K9O6P+akg/i4q2+0=; h=In-Reply-To:References:Subject:To:Cc:From:Date:From; b=BfaltBBaR63zw809ajWmqfGQDl/yVbLLDWguStR5cYjWJ/GgzUzhXBEZgQklIYe5v fyrtKZIvR7r6glea1WEmEK1XwPkZnPsKrbq4rytKZgyDLKVhQTIYVDHistTPyuxI9U ycHtK1Mcc4LGRHW4fgBSqIZvVxVQHjs3kGuHabuM= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20190625091002.27567-1-codrin.ciubotariu@microchip.com> Subject: Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1 To: Codrin.Ciubotariu@microchip.com, Ludovic.Desroches@microchip.com, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Stephen Boyd User-Agent: alot/0.8.1 Date: Mon, 22 Jul 2019 14:31:55 -0700 Message-Id: <20190722213156.8829E21900@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Nicolas.Ferre@microchip.com (2019-07-03 08:05:24) > On 25/06/2019 at 11:10, Codrin Ciubotariu wrote: > > In clk_generated_determine_rate(), if the divisor is greater than > > GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned. > > If clk_generated_set_rate() will be called later with this wrong > > rate, it will return -EINVAL, so the generated clock won't change > > its value. Do no let the divisor be greater than GENERATED_MAX_DIV + 1. > >=20 > > Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor = loop") > > Signed-off-by: Codrin Ciubotariu > > Acked-by: Nicolas Ferre > > Acked-by: Ludovic Desroches > > --- > >=20 > > - The email-server was converting my patches to base64, so I resend it > > using another server; > > - Added acked-bys from Nicolas and Ludovic; >=20 > Stephen, >=20 > I don't see this patch in linux-next and we're already late in the=20 > development cycle: aka ping... >=20 Sorry. I dropped this one. Will pick it up into fixes.